Add expected errors for benchmark test package [false positive test] #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mrodm commented Aug 13, 2024
| package_name_manifest=$(cat "$package_root/manifest.yml" | yq -r '.name') | ||
| local expected_errors_file="${package_root%/}.expected_errors" | ||
| local result_tests="build/test-results/${package_name}-*.xml" | ||
| local result_tests="build/test-results/${package_name_manifest}-*.xml" |
There was a problem hiding this comment.
Test results file names are using the package name defined in the manifest. Example:
build/test-results/rally_benchmarks-static-1723556393923280393.xml
mrodm commented Aug 13, 2024
| { | ||
| "@timestamp": "{{ $timestamp.Format "2006-01-02T15:04:05.999999Z07:00" }}", | ||
| "data_stream.type": "logs", | ||
| data_stream.type": "logs", |
There was a problem hiding this comment.
As it was this file, elastic-package test static did not detect any failure.
With this change, I tried to force a failure here (as mentioned in the README.md of the package).
mrodm commented Aug 13, 2024
jsoriano approved these changes Aug 14, 2024
jsoriano approved these changes Aug 14, 2024
💚 Build Succeeded
History
cc @mrodm |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follows #1718
Force to fail
rally_benchmark_malformed_templatetest package by updating thetemplate.ndjsonfile as suggested in the README.md:elastic-package/test/packages/false_positives/rally_benchmark_malformed_template/docs/README.md
Line 3 in f0272ca
This PR also adds the corresponding expected errors.