Fix race condition reading from PTTY #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mrodm approved these changes Jun 13, 2024
| /test |
1 similar comment
| /test |
💚 Build Succeeded
History
cc @jsoriano |
| Three builds green, I am merging this. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Execution of fast docker compose commands are getting stuck sometimes. One possible theory is that we are closing the pseudo-tty before the copy has finished, and it hangs there.
Close the pseudo-TTY after waiting for the finalization of the goroutine, so we avoid problems caused by closing it while it is being read.
Thanks @mrodm for reporting!