-
Couldn't load subscription status.
- Fork 128
Add github action to bump stack versions #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @mrodm do you know if there is any way to test these actions before merging? |
I think of two options
Not sure if it requires to create this PR in the upstream repository because of this: |
| - backport-skip | ||
| - build-monitoring | ||
| - Team:Beats-On-Call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say these three labels are not needed in elastic-package PRs.
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| needs: [filter] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no jobs filter defined. Probably, this job fails or could not start. Is it required another job here ?
I guess it is probably based on this workflow: https://github.com/elastic/beats/blob/d23b4d33622137f7245b628d77d15f8ecfef3a0d/.github/workflows/bump-elastic-stack-snapshot.yml#L16
Currently, the filter job looks like would not be needed. If so, this could be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this is a leftover from copying from beats.
This doesn't seem to work, I have tried different options but it doesn't seem to find the workflow.
Tried in #1854, but no luck.
I have modified the workflow in this PR to show only the diff and don't apply the changes, let me know if this is ok for you. We could merge this and change to apply after testing in a different PR. |
So at the end, it looks like it should be defined in main... I cannot think of any other ways to test this without merging.
Perfect, let's do it in that way 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These workflows looks good, let's merge it and try it 👍
| update-package-registry-base-image: | ||
| name: "Update Package Registry base image" | ||
| kind: file | ||
| sourceid: latestRegistryVersion | ||
| scmid: default | ||
| spec: | ||
| file: internal/stack/resources.go | ||
| matchpattern: '"(docker.elastic.co/package-registry/package-registry):v[0-9\.]+"' | ||
| replacepattern: '"$1:{{ source "latestRegistryVersion" }}"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works, we could remove the step to create this PR from other Buildkite job.
💚 Build Succeeded
History
cc @jsoriano |
| I can test changes in the workflow now that it is in main 👍 |
Add github action to automate bump of stack versions.
It bumps: