[Buildkite] Enable delete redshift clusters with dry_run false #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add trap function to ensure all files created during this process are deleted.
mrodm commented May 22, 2024
.buildkite/scripts/cloud-cleanup.sh Outdated
Comment on lines 189 to 193
| if ! aws redshift delete-cluster \ | ||
| --cluster-identifier "${identifier}" \ | ||
| --skip-final-cluster-snapshot \ | ||
| --output json \ | ||
| --query "Clusters[*].{ClusterStatus:ClusterStatus,ClusterIdentifier:ClusterIdentifier}" ; then |
There was a problem hiding this comment.
Just show those values from the response.
mrodm commented May 22, 2024
| IMAGE_UBUNTU_X86_64: "family/core-ubuntu-2204" | ||
| | ||
| steps: | ||
| - label: ":go: Run check-static" |
There was a problem hiding this comment.
I would restore this file before merging, in case it is needed to do more tests.
jsoriano reviewed May 22, 2024
catalog-info.yaml Outdated
| access_level: MANAGE_BUILD_AND_READ | ||
| everyone: | ||
| access_level: BUILD_AND_READ | ||
| access_level: READ_ONLY |
jsoriano approved these changes May 22, 2024
| /test |
1 similar comment
| /test |
💚 Build Succeeded
History
cc @mrodm |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Enable in cloud cleanup pipeline the action to delete Redshift Clusters when DRY_RUN is set to false.
Currently, keep DRY_RUN=true by default when it is triggered the pipeline automatically, since it has not been tested for the other resources.