Skip to content

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Apr 16, 2024

Ensure that elastic-package benchmark system command is run for system_benchmark test package (under with-logstash folder).

Currently, for this test package is run the elastic-package test command:
https://buildkite.com/elastic/elastic-package/builds/2823#018ee67c-5012-4841-b76a-9343105e1fe1/80-633

+ for d in test/packages/${PACKAGE_TEST_TYPE:-other}/${PACKAGE_UNDER_TEST:-*}/ + cd test/packages/with-logstash/system_benchmark/ + '[' with-logstash == benchmarks ']' + '[' with-logstash == with-logstash ']' + '[' '*' == system_benchmark ']' + elastic-package test -v --report-format xUnit --report-output file --defer-cleanup 1s --test-coverage --coverage-format=generic 2024/04/16 10:46:15 DEBUG Enable verbose logging 

With this PR, it executes the elastic-package benchmark system :
https://buildkite.com/elastic/elastic-package/builds/2834#018ee744-75f6-460b-8ced-b864e8ff9a6b/111-660

+ cd test/packages/with-logstash/system_benchmark/ ++ basename test/packages/with-logstash/system_benchmark/ + package_to_test=system_benchmark + '[' with-logstash == benchmarks ']' + '[' with-logstash == with-logstash ']' + '[' system_benchmark == system_benchmark ']' + elastic-package benchmark system --benchmark logs-benchmark -v --defer-cleanup 1s 

Relates #1615

@mrodm mrodm self-assigned this Apr 16, 2024
@mrodm mrodm marked this pull request as ready for review April 16, 2024 14:39
@mrodm mrodm requested review from a team and bhapas April 16, 2024 14:39
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mrodm mrodm merged commit 0dda40a into elastic:main Apr 17, 2024
@mrodm mrodm deleted the update_system_bench_logstash branch April 17, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants