-
Couldn't load subscription status.
- Fork 128
Add redshift check cloud cleanup #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Adrien Mannocci <adrien.mannocci@gmail.com>
Pending to remove cloud cleanup step.
| resources: | ||
| - type: 'node' | ||
| regions: | ||
| - us-east-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have the region in some environment variable that we could use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, it is using the default region set in the terraform files, there is no value set in our scripts. For instance:
elastic-package/test/packages/parallel/aws/data_stream/ec2_metrics/_dev/deploy/tf/env.yml
Line 9 in e74c021
| - AWS_REGION=${AWS_REGION:-us-east-1} |
Should we add a value there in our scripts for both repositories or rely on that default value?
Currently, all terraform tags are set in the pre-command hook:
| # variables required for terraform |
Maybe, we could add/set there the variable export AWS_REGION=us-east-1 too.
.buildkite/scripts/cloud-cleanup.sh Outdated
| --context "ctx-cloud-reaper-error" \ | ||
| --style "error" | ||
| fi | ||
| exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to exit here? We could continue and check other resources, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I forgot to remove this exit!
I've updated the code to allow running all steps and just exit with failure at the end.
💚 Build Succeeded
History
cc @mrodm |
Add checks into cloud cleanup script so it is sent an email notification if there is any redshift cluster stale related to CI (integrations or elastic-package).
To be replaced by
cloud-reapderwhen there is support for this kind of resources.Example of build with this cloud cleanup step:
https://buildkite.com/elastic/elastic-package/builds/2527
Added input steps when this pipeline is triggered from the UI.
Relates #1700