Remove exception for uninstalling system package in tests #1676
Conversation
| // by default system package is part of an agent policy and it cannot be uninstalled | ||
| // https://github.com/elastic/elastic-package/blob/5f65dc29811c57454bc7142aaf73725b6d4dc8e6/internal/stack/_static/kibana.yml.tmpl#L62 |
There was a problem hiding this comment.
Elastic stacks with version 7.17.* still have system package installed (tested with 7.17.18).
Would that be a problem to remove this exception ? @elastic/ecosystem
Looking at the latest system package version , it requires Kibana version ^8.12.0
https://github.com/elastic/integrations/blob/92900f6c0eb9cdc449808d8fd1dc234d05cf7f93/packages/system/manifest.yml#L11
There was a problem hiding this comment.
Ah, you are right, actually the part of the template modified in https://github.com/elastic/elastic-package/pull/1672/files#diff-df47a0840eb947003447c6e44e2fbec3f13b1ffda4478b46ba2cced8f4ae2fc6R51 is only used starting on 8.0.0.
In 7.x probably this policy was hard-coded in Kibana, so we will need to keep the exception at least for 7.x.
There was a problem hiding this comment.
Re-added this exception but just for Elastic stack 7.* in this commit 7d4c3f5
💚 Build Succeeded
History
cc @mrodm |
3 participants
This PR removes the exception that was set in place for
systempackage when packages were uninstalled in the tear down process (asset and system tests).In #1672,
systempackage is no longer installed in the default Agent policy, so there should not be any error whensystempackage is uninstalled from now on.systempackage in integrations repository locally (Elastic stack 8.12.1)Relates: