Use docker subcommand when available #1592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
💚 Build Succeeded
cc @jsoriano |
| test integrations |
| Created or updated PR in integrations repository to test this version. Check elastic/integrations#8707 |
mrodm approved these changes Dec 12, 2023
There was a problem hiding this comment.
LGTM
That means that could it be removed docker-compose from the Buildkite pipelines of the integrations repo too ?
In principle yes! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Recent versions of the Docker CLI include docker compose. Use it when available instead of standalone
docker-compose.The environment variable
ELASTIC_PACKAGE_COMPOSE_ENABLE_STANDALONE=truecan be used to force the use of standalonedocker-compose.Fixes #1306