Skip to content

Handle error when finalizing multipart message #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2023
Merged

Handle error when finalizing multipart message #1569

merged 1 commit into from
Nov 27, 2023

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented Nov 27, 2023 •
edited
Loading

This stop can fail if it cannot write the trailing boundary. Unlikely to happen, but let's handle it to avoid weird errors later.

Renamed also some files in the package to avoid underscores in file names.
@jsoriano jsoriano requested a review from a team November 27, 2023 18:38
@jsoriano jsoriano self-assigned this Nov 27, 2023
@jsoriano jsoriano mentioned this pull request Nov 27, 2023
Merged
kpollich
kpollich approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is simple LGTM 🚀
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @jsoriano
@jsoriano jsoriano merged commit 812292e into elastic:main Nov 27, 2023
@jsoriano jsoriano deleted the error-handling-multipart-close branch November 27, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@jsoriano @elasticmachine @kpollich