Skip to content

Conversation

@kaiyan-sheng
Copy link
Contributor

source_dataset, if condition, target_dataset and namespace are all optional according to reroute processor documentation. This PR is to add support in elastic-package for routing_rules.yml to have optional configs.

closes #1389

@kaiyan-sheng kaiyan-sheng self-assigned this Aug 11, 2023
@jsoriano jsoriano requested a review from mrodm August 14, 2023 09:44
@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review August 16, 2023 23:10
@kaiyan-sheng kaiyan-sheng requested a review from jsoriano August 16, 2023 23:10
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I see I have a pending review 🤦

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kaiyan-sheng

@kaiyan-sheng kaiyan-sheng merged commit 9dda66f into elastic:main Sep 12, 2023
@kaiyan-sheng kaiyan-sheng deleted the routing_rules_optional_fields branch September 12, 2023 17:19
bhapas pushed a commit to bhapas/elastic-package that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants