opamp: ack remote config status changes #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Start reporting ReportsRemoteConfig agent capability and sending an ack to the server when we update our config based on the remote one. This rework the opamp handler signature to also take the agent as we need to enqueue a remote config status message to ack the updated configuration.
| Oh, there is the typecheck CI failure as well. |
basepi approved these changes Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Start reporting ReportsRemoteConfig agent capability and sending an ack to the server when we update our config based on the remote one. This rework the opamp handler signature to also take the agent as we need to enqueue a remote config status message to ack the updated configuration.
Related issues
Closes #332