distro: remove custom code in ElasticOpenTelemetryConfigurator #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The custom code was introduced in 40ae8be for changing the semantics of the logs sdk. Since the semantic has been changed upstream too we can drop our custom code. While at it add an integration test to check that events are emitted.
xrmx force-pushed the redundant-distro-setup branch from 93bc13e to 533c59f Compare 
trentm approved these changes Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
The custom code was introduced in 40ae8be for changing the semantics of the logs sdk. Since the semantic has been changed upstream too we can drop our custom code.
While at it add an integration test to check that events are emitted.
Related issues
Closes #245