Skip to content

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Aug 22, 2024

What does this pull request do?

Builds out minimal viable docs. At a minimum, distribution docs should answer all of the following questions:

  • What is the product?
  • Why would someone use the product?
    • What problem does it solve?
  • How does the product fit into the larger ecosystem?
    • In this case, both the Elastic and OpenTelemetry ecosystems.
  • Does the product have any dependencies?
  • Where can the user acquire the product?
    • If there are multiple options, provide guidance on how to choose the best approach.
  • How does the user install the product?
    • If there are multiple options, provide guidance on how to choose the best approach.
  • What are the basic configuration options?
  • How does the user set configuration options?
  • What does a simple start-to-finish operation look like?
    • Include a description of what the user will see if the operation has completed successfully.

The initial commit includes the overall structure, but there is some information that is missing or needs to be validated. I've left code comments with questions to be answered throughout the files.

Read more about what needs to be included in these docs in Elastic Distributions of OpenTelemetry (Mini docs style guide) (internal doc).

To do

  • @colleenmcginnis add initial draft with questions for the dev team in code comments
  • @elastic/apm-agent-python review initial draft content, respond to questions in code comments
    • Feel free to either commit directly to this PR or add suggestions in PR comments — whichever works best for you!
  • @colleenmcginnis address comments, clean up content
  • @elastic/apm-agent-python review final draft
  • @colleenmcginnis address comments
  • @elastic/apm-agent-python approve and merge

Related issues

Closes https://github.com/elastic/obs-docs-team/issues/241

@colleenmcginnis colleenmcginnis requested a review from a team August 22, 2024 14:57
@colleenmcginnis colleenmcginnis self-assigned this Aug 22, 2024
Copy link
Member

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a first round of comments, thank you very much!

@colleenmcginnis colleenmcginnis requested a review from xrmx August 23, 2024 18:25
@colleenmcginnis
Copy link
Contributor Author

@xrmx I'm not sure if I should make any changes related to these two comments #110 (comment) and #110 (comment) or if we should hold this PR until the next release. Let me know what you would like to do!

@xrmx
Copy link
Member

xrmx commented Aug 30, 2024 via email

@xrmx xrmx marked this pull request as ready for review September 3, 2024 13:19
@xrmx xrmx enabled auto-merge (squash) September 5, 2024 07:51
Copy link
Member

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xrmx xrmx merged commit ecb8959 into elastic:main Sep 5, 2024
10 checks passed
@colleenmcginnis colleenmcginnis deleted the prep-docs branch September 5, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants