Skip to content

Conversation

intxgo
Copy link
Contributor

@intxgo intxgo commented Sep 2, 2025

What does this PR do?

Adds exit code 284 to non fatal exit codes for endpoint security component.

Why is it important?

See related issues, the change introduced only posix exit code.

Background story: The exit code was 284 since the beginning for all platforms, but later on we changed it for posix to fix bash scripts. The problem is that shell scripts expect byte size return codes, so 284 becomes 28 when casted to byte size.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...
@intxgo intxgo requested a review from a team as a code owner September 2, 2025 14:19
@intxgo intxgo requested review from kaanyalti and nkvoll September 2, 2025 14:19
@mergify mergify bot assigned intxgo Sep 2, 2025
Copy link
Contributor

mergify bot commented Sep 2, 2025

This pull request does not have a backport label. Could you fix it @intxgo? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.
@intxgo
Copy link
Contributor Author

intxgo commented Sep 2, 2025

@ycombinator was your PR already included in any release? If not, I guess we can simply skip release notes fragment for this quick fix.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Sep 2, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ebeahan ebeahan requested review from pchila and removed request for nkvoll September 2, 2025 21:06
@cmacknz cmacknz requested a review from ycombinator September 3, 2025 15:30
@cmacknz cmacknz added the backport-active-all Automated backport with mergify to all the active branches label Sep 3, 2025
@cmacknz
Copy link
Member

cmacknz commented Sep 3, 2025

You need a changelog fragment, the CI failure for FIPS should hopefully be resolved now.

@cmacknz cmacknz enabled auto-merge (squash) September 3, 2025 18:23
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 3, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @intxgo

@cmacknz cmacknz merged commit c022c77 into elastic:main Sep 3, 2025
19 checks passed
Copy link
Contributor

github-actions bot commented Sep 3, 2025

@Mergifyio backport 8.17 8.18 8.19 9.0 9.1

Copy link
Contributor

mergify bot commented Sep 3, 2025

mergify bot pushed a commit that referenced this pull request Sep 3, 2025
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77)
mergify bot pushed a commit that referenced this pull request Sep 3, 2025
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77)
mergify bot pushed a commit that referenced this pull request Sep 3, 2025
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77)
mergify bot pushed a commit that referenced this pull request Sep 3, 2025
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77)
mergify bot pushed a commit that referenced this pull request Sep 3, 2025
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77)
cmacknz pushed a commit that referenced this pull request Sep 4, 2025
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77) Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>
cmacknz pushed a commit that referenced this pull request Sep 4, 2025
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77) Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>
cmacknz pushed a commit that referenced this pull request Sep 4, 2025
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77) Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>
cmacknz pushed a commit that referenced this pull request Sep 4, 2025
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77) Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>
cmacknz pushed a commit that referenced this pull request Sep 4, 2025
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77) Co-authored-by: Leszek Kubik <39905449+intxgo@users.noreply.github.com>
kaanyalti pushed a commit to kaanyalti/elastic-agent that referenced this pull request Sep 4, 2025
* add non-fatal endpoint security exit code * add pr fragment
Rohit-code14 pushed a commit to Rohit-code14/elastic-agent that referenced this pull request Sep 5, 2025
* add non-fatal endpoint security exit code * add pr fragment
intxgo added a commit to intxgo/elastic-agent that referenced this pull request Sep 24, 2025
* add non-fatal endpoint security exit code * add pr fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

4 participants