- Notifications
You must be signed in to change notification settings - Fork 197
add non-fatal endpoint security exit code #9687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request does not have a backport label. Could you fix it @intxgo? 🙏
|
@ycombinator was your PR already included in any release? If not, I guess we can simply skip release notes fragment for this quick fix. |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
You need a changelog fragment, the CI failure for FIPS should hopefully be resolved now. |
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @intxgo |
@Mergifyio backport 8.17 8.18 8.19 9.0 9.1 |
✅ Backports have been created
|
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77)
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77)
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77)
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77)
* add non-fatal endpoint security exit code * add pr fragment (cherry picked from commit c022c77)
* add non-fatal endpoint security exit code * add pr fragment
* add non-fatal endpoint security exit code * add pr fragment
* add non-fatal endpoint security exit code * add pr fragment
What does this PR do?
Adds exit code 284 to non fatal exit codes for endpoint security component.
Why is it important?
See related issues, the change introduced only posix exit code.
Background story: The exit code was 284 since the beginning for all platforms, but later on we changed it for posix to fix bash scripts. The problem is that shell scripts expect byte size return codes, so 284 becomes 28 when casted to byte size.
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Relates Allow Endpoint service to keep running if its
install
exit code is non-fatal #9320Questions to ask yourself