Fix minor typo in beats update job #8233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was an unnecessary "$" in there. As a result, we never skipped the update even when it wasn't necessary.
swiatekm added Team:Elastic-Agent-Control-Plane 
| Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
v1v approved these changes May 23, 2025
mergify bot pushed a commit that referenced this pull request May 23, 2025
There was an unnecessary "$" in there. As a result, we never skipped the update even when it wasn't necessary. (cherry picked from commit 9419db9)
swiatekm added a commit that referenced this pull request May 23, 2025
v1v added a commit to v1v/elastic-agent that referenced this pull request May 27, 2025
* main: chore: Update to elastic/beats@c51fee3a852e (elastic#8246) chore: Update to elastic/beats@82f47f73acbd (elastic#8239) Fix minor typo in beats update job (elastic#8233) fix(diagnostics): handle log rotation races (elastic#8215) Fix some minor issues with the beats version update job (elastic#8224) [main][Automation] Update elastic/beats to 9382cc20546b (elastic#8222) Automatically update beats module versions (elastic#8174) chore: deps(ironbank): Bump ubi version to 9.6 (elastic#8218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the updatecli condition check if the update was necessary, here was an unnecessary
$. As a result, we never skipped the update.Tested this locally and it looked correct.