Adding new configuration setting: agent.upgrade.rollback.window

[ycombinator]

What does this PR do?

This PR adds a new optional Agent configuration setting, agent.upgrade.rollback.window. This setting takes a string parseable by time.Duration(). The default value of this setting is 168h (== 7 days). The value of this setting will determine how long after users upgrade an Agent will they be permitted to request a rollback to the previous version of the Agent on disk.

Why is it important?

To allow users to perform manual rollbacks of upgraded Elastic Agent within a certain time window.

Checklist

• I have read and understood the pull request guidelines of this project.
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in ./changelog/fragments using the changelog tool
• I have added an integration test or an E2E test

Disruptive User Impact

None; this PR adds a new, optional setting. Further, older versions of Elastic Agent will ignore this setting if they encounter it.

How to test this PR locally

$ echo "agent.upgrade.rollback.window: 12h" >> ./elastic-agent.yml $ go build . $ ./elastic-agent inspect # check that this contains the new setting in it 

Related issues

• Resolves Add rollback_window to elastic agent configuration with a default value of 7d #6881

Questions to ask yourself

• How are we going to support this in production?
• How are we going to measure its adoption?
• How are we going to debug this?
• What are the metrics I should take care of?
• ...

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[mergify]

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
• backport-active-all is the label that automatically backports to all active branches.
• backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
• backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

[blakerouse]

Looks good. All unit tests and integration tests pass. Only failure is related to check-ci and then change to elastic-agent.reference.yml.

[pchila]

Left a couple of nitpicks about the new settings description, not blocking. Feel free to resolve them if you think those are unnecessary.
LGTM

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 98e3528

Failed CI Steps

• Serverless integration test
• x86_64:sudo: default

History

• 💔 Build #20945 failed 40ffcbe
• 💔 Build #20943 failed 7c838f0
• 💚 Build #20870 succeeded b0f88e2
• 💔 Build #20851 failed a7505d9
• 💔 Build #20847 failed 624d614

cc @ycombinator