- Notifications
You must be signed in to change notification settings - Fork 197
Add ability to enroll with defined ID and replace_token #6498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request does not have a backport label. Could you fix it @blakerouse? 🙏
|
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Allows an Elastic Agent to enroll with a defined ID and replacement token to allow it to replace an existing Elastic Agent. The original Elastic Agent must have also been enrolled with the same --replace-token or it will not be allow to enroll if the --id collides with an existing Elastic Agent. (cherry picked from commit 8a878fc)
Allows an Elastic Agent to enroll with a defined ID and replacement token to allow it to replace an existing Elastic Agent. The original Elastic Agent must have also been enrolled with the same --replace-token or it will not be allow to enroll if the --id collides with an existing Elastic Agent. (cherry picked from commit 8a878fc)
Allows an Elastic Agent to enroll with a defined ID and replacement token to allow it to replace an existing Elastic Agent. The original Elastic Agent must have also been enrolled with the same --replace-token or it will not be allow to enroll if the --id collides with an existing Elastic Agent. (cherry picked from commit 8a878fc) Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Allows an Elastic Agent to enroll with a defined ID and replacement token to allow it to replace an existing Elastic Agent. The original Elastic Agent must have also been enrolled with the same --replace-token or it will not be allow to enroll if the --id collides with an existing Elastic Agent. (cherry picked from commit 8a878fc) Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
@theletterf @nimarezainia do we have any follow up actions here in order to document this for Kubernetes use case at least? |
@jlind23 I don't see an issue if we wanted to document this option for users who want to reuse the agent.id - but we haven't documented this yet as far as I know. |
I take this is for Elastic Agent docs, not EDOT docs, right? I'd be happy to review a docs PR on this. |
yes at the moment only applies to elastic agent docs. |
@nimarezainia are you taking this one or shall I kindly ask @ebeahan to find someone? |
@jlind23 maybe I'm confused. This ask is for just documentation of the install flag |
I guess Julien was hinting precisely at who would open the documentation PR. :) I'll check with the team and see to it. |
I’ve created a docs issue to document this, so it’s on our radar. |
What does this PR do?
Adds new
--id
(ELASTIC_AGENT_ID
env for container) and--replace-token
(FLEET_REPLACE_TOKEN
env for container) to enrollment.Why is it important?
Allows an Elastic Agent to enroll with a defined ID and replacement token to allow it to replace an existing Elastic Agent. The original Elastic Agent must have also been enrolled with the same
--replace-token
or it will not be allow to enroll if the--id
collides with an existing Elastic Agent.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files(no config changes)[ ] I have added tests that prove my fix is effective or that my feature works(cannot unit test)./changelog/fragments
using the changelog toolDisruptive User Impact
None
How to test this PR locally
You need this PR (elastic/fleet-server#4290) from Fleet Server and have that Fleet Server running to enroll. Then you can build this PR and run enroll with
--id
and--replace-token
.Related issues