Skip to content

github-actions: filter by current active branches in the repository #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2025
Merged

github-actions: filter by current active branches in the repository #6326

merged 2 commits into from
Feb 5, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Dec 13, 2024 •
edited
Loading

What does this PR do?

Filter by the current active branches in elastic/elastic-agent

Why is it important?

https://github.com/elastic/oblt-actions/tree/v1/elastic/active-branches supports now filtering the branches from the Unified Release that are available in this repository.

This can help with cases when the release branch has not been created yet

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

I ran https://github.com/elastic/elastic-agent/actions/runs/12314405668

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...
@v1v v1v self-assigned this Dec 13, 2024
@v1v v1v requested a review from a team as a code owner December 13, 2024 10:46
@v1v v1v requested a review from rdner December 13, 2024 11:14
@rowlandgeoff
Copy link
Contributor

skip-ci is essentially ineffective since we have required checks. If they're required and we skip them, we're stuck.
@rowlandgeoff
Copy link
Contributor

/test
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube
@swiatekm swiatekm added Team:Ingest-EngProd Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jan 17, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)
@v1v v1v requested a review from a team February 5, 2025 13:36
@v1v v1v enabled auto-merge (squash) February 5, 2025 13:54
dliappis
dliappis approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@v1v v1v merged commit b1d75ec into main Feb 5, 2025
8 checks passed
@v1v v1v deleted the feature/support-branches-that-are-available-only branch February 5, 2025 15:16
blakerouse pushed a commit to blakerouse/elastic-agent that referenced this pull request Feb 5, 2025
@v1v @blakerouse
github-actions: filter by current active branches in the repository (e…
ed6a475 
…lastic#6326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Ingest-EngProd

5 participants

@v1v @rowlandgeoff @elasticmachine @dliappis @swiatekm