Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 31, 2025

What does this PR do?

This PR adds the required environment variables (EC_ENDPOINT and ESS_REGION) to all FIPS integration test steps in the Buildkite pipeline to ensure proper ESS (Elastic Stack Service) stack provisioning during test retrying.

Why is it important?

Without these environment variables, retried FIPS integration test steps fail to provision ESS stacks correctly, causing test failures. This issue was discovered when investigating this failed build, where every retried FIPS step failed ESS stack provisioning due to the missing EC_ENDPOINT configuration (at least this is my working theory).

Interestingly, retried fips:x86_64:sudo-false:fleet CI steps appeared successful, but further investigation revealed they don't actually run any tests, which masked the underlying issue.

This fix ensures that all FIPS integration tests have the correct environment configuration regardless of whether they are initial runs or retried steps.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

No disruptive user impact. This change only affects the CI pipeline configuration and does not modify any user-facing functionality.

How to test this PR locally

This change affects the Buildkite CI pipeline configuration.

Related issues

N/A


This is an automatic backport of pull request #10943 done by Mergify.

@mergify mergify bot added the backport label Oct 31, 2025
@mergify mergify bot requested review from a team as code owners October 31, 2025 13:28
@mergify mergify bot requested review from pkoutsovasilis and swiatekm and removed request for a team October 31, 2025 13:28
@mergify mergify bot added the backport label Oct 31, 2025
@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Oct 31, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

pkoutsovasilis
pkoutsovasilis previously approved these changes Oct 31, 2025
@pkoutsovasilis pkoutsovasilis enabled auto-merge (squash) October 31, 2025 13:34
@pkoutsovasilis pkoutsovasilis dismissed their stale review October 31, 2025 13:35

the staging FIPS-complaint cloud env isn't enabled here

@pkoutsovasilis pkoutsovasilis merged commit 205c944 into 9.2 Oct 31, 2025
24 checks passed
@pkoutsovasilis pkoutsovasilis deleted the mergify/bp/9.2/pr-10943 branch October 31, 2025 16:45
@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

cc @pkoutsovasilis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants