Skip to content

Conversation

@rogercoll
Copy link
Contributor

What does this PR do?

Adds a version check before trying to push version changes.

Why is it important?

Prevents the CI from failing if there are no changes to be committed: https://github.com/elastic/elastic-agent/actions/runs/18953576366/job/54126615230

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...
@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2025

This pull request does not have a backport label. Could you fix it @rogercoll? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'd like a couple of executions of this updatecli manifest:

  • with new changes
  • without new changes

So we can see how it behaves before merging it? Do you mind sharing them?

@rogercoll
Copy link
Contributor Author

LGTM, although I'd like a couple of executions of this updatecli manifest:

* with new changes * without new changes 

So we can see how it behaves before merging it? Do you mind sharing them?

With new changes

+++++++++++ + PREPARE + +++++++++++ Loading Pipeline ".ci/updatecli/updatecli-bump-kube-stack.yml" SCM repository retrieved: 1 ++++++++++++++++++ + AUTO DISCOVERY + ++++++++++++++++++ ++++++++++++ + PIPELINE + ++++++++++++ ############################################################### # BUMP OPENTELEMETRY KUBE STACK HELM CHART TO LATEST VERSIONS # ############################################################### source: source#opentelemetry-kube-stack-helm ------------------------------------ Searching for version matching pattern "*" ✔ Helm Chart "opentelemetry-kube-stack" version "0.11.1" is found from repository "https://open-telemetry.github.io/opentelemetry-helm-charts" source: source#current-kube-stack ------------------------- ✔ content: found from file "testing/integration/k8s/k8s.go": KubeStackChartVersion = "0.11.1" condition: condition#is-new-version ------------------------ The shell 🐚 command "/bin/sh /tmp/updatecli/bin/89eff2a092ded2df5db2c4b1c495aef812b523458735d54087988b298fe3edd5.sh" exited on error (exit code 2) with the following output: ---- ---- command stderr output was: ---- /tmp/updatecli/bin/89eff2a092ded2df5db2c4b1c495aef812b523458735d54087988b298fe3edd5.sh: line 1: [: too many arguments ---- shell command failed. Expected exit code 0 but got 2 ✗ shell condition of type "console/output" not passing target: target#update-tested-kube-stack ------------------------------- target: target#update-testdata ---------------------- ACTIONS ======== Bump OpenTelemetry Kube Stack Helm Chart to latest versions => Bump OpenTelemetry Kube Stack Helm Chart to latest versions No follow up action needed ============================= SUMMARY: - Bump OpenTelemetry Kube Stack Helm Chart to latest versions: Source: ✔ [current-kube-stack] ✔ [opentelemetry-kube-stack-helm] Get latest OpenTelemetry Kube Stack Helm Chart release Condition: ✗ [is-new-version] Succeeds if the latest OpenTelemetry Kube-Stack Helm Chart version is different than the one in testing/integration/k8s/k8s.go Target: - [update-testdata] Update local OpenTelemetry Kube Stack Helm Chart files - [update-tested-kube-stack] Update tested OpenTelemetry Kube Stack Helm Chart in k8s.go Run Summary =========== Pipeline(s) run: * Changed: 0 * Failed: 0 * Skipped: 1 * Succeeded: 0 * Total: 1 

without new changes

+++++++++++ + PREPARE + +++++++++++ Loading Pipeline ".ci/updatecli/updatecli-bump-kube-stack.yml" SCM repository retrieved: 1 ++++++++++++++++++ + AUTO DISCOVERY + ++++++++++++++++++ ++++++++++++ + PIPELINE + ++++++++++++ ############################################################### # BUMP OPENTELEMETRY KUBE STACK HELM CHART TO LATEST VERSIONS # ############################################################### source: source#opentelemetry-kube-stack-helm ------------------------------------ Searching for version matching pattern "*" ✔ Helm Chart "opentelemetry-kube-stack" version "0.11.1" is found from repository "https://open-telemetry.github.io/opentelemetry-helm-charts" target: target#update-tested-kube-stack ------------------------------- ✔ - all contents from 'file' and 'files' combined already up to date CHANGELOG: ---------- Title: unknown Published At: 2025-10-09 18:09:54.070816722 +0000 UTC Link: Description: Remark: We couldn't identify a way to automatically retrieve changelog information. Please use following information to take informed decision Helm Chart: opentelemetry-kube-stack OpenTelemetry Quickstart chart for Kubernetes. Installs an operator and collector for an easy way to get started with Kubernetes observability. Project Home: https://opentelemetry.io/ Version created on the 2025-10-09 18:09:54.070816722 +0000 UTC Sources: * https://github.com/open-telemetry/opentelemetry-operator URL: * https://github.com/open-telemetry/opentelemetry-helm-charts/releases/download/opentelemetry-kube-stack-0.11.1/opentelemetry-kube-stack-0.11.1.tgz target: target#update-testdata ---------------------- The shell 🐚 command "/bin/sh /tmp/updatecli/bin/95a63d9c20c1f6ed587e96cf95f0b74041998e0c679aaa77af06bbb41afa3e28.sh" ran successfully with the following output: ---- ~~~ Running mage integration:buildKubernetesTestData ---- ⚠ - ran shell command ".ci/scripts/update-integration-testdata.sh 0.11.1" CHANGELOG: ---------- Title: unknown Published At: 2025-10-09 18:09:54.070816722 +0000 UTC Link: Description: Remark: We couldn't identify a way to automatically retrieve changelog information. Please use following information to take informed decision Helm Chart: opentelemetry-kube-stack OpenTelemetry Quickstart chart for Kubernetes. Installs an operator and collector for an easy way to get started with Kubernetes observability. Project Home: https://opentelemetry.io/ Version created on the 2025-10-09 18:09:54.070816722 +0000 UTC Sources: * https://github.com/open-telemetry/opentelemetry-operator URL: * https://github.com/open-telemetry/opentelemetry-helm-charts/releases/download/opentelemetry-kube-stack-0.11.1/opentelemetry-kube-stack-0.11.1.tgz ERROR: something went wrong in "target#update-testdata" : something went wrong in target "update-testdata" : "no changed file to commit" Pipeline "Bump OpenTelemetry Kube Stack Helm Chart to latest versions" failed Skipping due to: something went wrong during target execution ACTIONS ======== ERROR: 1 target(s) (update-testdata) failed for action "elastic-agent" Bump OpenTelemetry Kube Stack Helm Chart to latest versions => Bump OpenTelemetry Kube Stack Helm Chart to latest versions No follow up action needed ============================= SUMMARY: ✗ Bump OpenTelemetry Kube Stack Helm Chart to latest versions: Source: ✔ [opentelemetry-kube-stack-helm] Get latest OpenTelemetry Kube Stack Helm Chart release Target: ✗ [update-testdata] Update local OpenTelemetry Kube Stack Helm Chart files ✔ [update-tested-kube-stack] Update tested OpenTelemetry Kube Stack Helm Chart in k8s.go Run Summary =========== Pipeline(s) run: * Changed: 0 * Failed: 1 * Skipped: 0 * Succeeded: 0 * Total: 1 ERROR: ✗ 1 over 1 pipeline failed ERROR: command failed: 1 over 1 pipeline failed 
@swiatekm swiatekm requested a review from v1v October 31, 2025 11:31
@v1v
Copy link
Member

v1v commented Oct 31, 2025

Sorry for the misleading about * without new changes, I meant if the version matches the one, so what's the output of updatecli when running the same manifest

But if you have already tested all good here

@rogercoll rogercoll merged commit 410a053 into elastic:main Oct 31, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants