- Notifications
You must be signed in to change notification settings - Fork 198
ci: skip file update if no changes #10942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| This pull request does not have a backport label. Could you fix it @rogercoll? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I'd like a couple of executions of this updatecli manifest:
- with new changes
- without new changes
So we can see how it behaves before merging it? Do you mind sharing them?
With new changes without new changes |
| Sorry for the misleading about But if you have already tested all good here |
What does this PR do?
Adds a version check before trying to push version changes.
Why is it important?
Prevents the CI from failing if there are no changes to be committed: https://github.com/elastic/elastic-agent/actions/runs/18953576366/job/54126615230
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself