- Notifications
You must be signed in to change notification settings - Fork 198
feat: move edot in a separate package #10922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: move edot in a separate package #10922
Conversation
c69eb19 to b93684f Compare | The fips related failures should be resolved by this PR |
| Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me at first glance. I checked this out and tried locally doing some of the things it changes, like updating the otel core version, and it all worked correctly.
I do think we should change the edot/pkg package name, but I'm not going to block this PR on it. Once CI passes, I'll approve it.
b93684f to 81e97fc Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I only reviewed the files in the folder .ci
| This pull request is now in conflicts. Could you fix it? 🙏 |
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
| This pull request is now in conflicts. Could you fix it? 🙏 |
What does this PR do?
This PR introduces EDOT (Elastic Distribution for OpenTelemetry) as a separate repository sub-package by moving code from
internal/pkg/oteltointernal/edot. This is a pure refactoring/relocation change with no functional modifications. Specifically:internal/pkg/otel/*tointernal/edot/pkg/*github.com/elastic/elastic-agent/internal/pkg/otel/...togithub.com/elastic/elastic-agent/internal/edot/pkg/...update:beats,otel:readme, etc., and scripts to reference the new package locationgo.modandgo.sumto reflect the new import pathsChanges summary: 50 files changed, +53,172 additions, -50,175 deletions (the large diff is primarily due to
go.mod/go.sum/NOTICE*.txtregeneration and mechanical import path updates)Why is it important?
This change is the second step in the incremental approach to separate EDOT from elastic-agent (as outlined in PR #9308). Introducing EDOT as a separate sub-package provides:
go.modinternal/edot/makes it straightforward to later extract it as a separate module or even repositoryThis follows the incremental approach decided by the team to split the large PR #9308 into smaller, reviewable chunks.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
None. This is a pure internal code reorganisation with no changes to functionality, APIs, configuration, or user-facing behaviour. The change is completely transparent to end users.
How to test this PR locally
Since this is a refactoring PR with no functional changes, testing focuses on ensuring everything continues to work as before, everything should work as before. So run any/all unit-test and/or integration test.
Related issues
N/A