- Notifications
You must be signed in to change notification settings - Fork 204
Correctly handle unix signals in EDOT #10908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| This pull request does not have a backport label. Could you fix it @swiatekm? 🙏
|
66ab2db to 451a72b Compare 451a72b to 82b73f9 Compare Contributor
| Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
ycombinator reviewed Oct 31, 2025
ycombinator reviewed Oct 31, 2025
ycombinator reviewed Oct 31, 2025
Contributor
💚 Build Succeeded
History
cc @swiatekm |
ycombinator approved these changes Nov 3, 2025
Contributor
| @Mergifyio backport 8.19 9.1 9.2 |
Contributor
✅ Backports have been created
|
mergify bot pushed a commit that referenced this pull request Nov 3, 2025
* Handle unix signals in EDOT * Add changelog entry * Fix changelog entry * Move removing agent config file to fixture.ConfigureOtel (cherry picked from commit 40bc68c)
6 tasks
mergify bot pushed a commit that referenced this pull request Nov 3, 2025
* Handle unix signals in EDOT * Add changelog entry * Fix changelog entry * Move removing agent config file to fixture.ConfigureOtel (cherry picked from commit 40bc68c)
mergify bot pushed a commit that referenced this pull request Nov 3, 2025
* Handle unix signals in EDOT * Add changelog entry * Fix changelog entry * Move removing agent config file to fixture.ConfigureOtel (cherry picked from commit 40bc68c)
This was referenced Nov 3, 2025
ebeahan pushed a commit that referenced this pull request Nov 3, 2025
swiatekm added a commit that referenced this pull request Nov 4, 2025
* Correctly handle unix signals in EDOT (#10908) * Handle unix signals in EDOT * Add changelog entry * Fix changelog entry * Move removing agent config file to fixture.ConfigureOtel (cherry picked from commit 40bc68c) * Fix conflict * Fix assertion in otel shutdown test --------- Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
ebeahan pushed a commit that referenced this pull request Nov 4, 2025
hayotbisonai pushed a commit to hayotbisonai/elastic-agent that referenced this pull request Nov 23, 2025
* Handle unix signals in EDOT * Add changelog entry * Fix changelog entry * Move removing agent config file to fixture.ConfigureOtel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-all Automated backport with mergify to all the active branches bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It makes the EDOT collector handle unix signals correctly.
Why is it important?
The EDOT collector should shut down gracefully when receiving a SIGINT or SIGTERM. If it doesn't, there's potential for resources not being freed or state on disk being corrupted.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolHow to test this PR locally
Use the following configuration:
Run the edot collector with it and send a SIGINT or SIGTERM to it. You'll see the components shut down before the collector exits.
Related issues