Skip to content

[deploy/kubernetes]: add info about hostPID for Universal Profiling #10173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

[deploy/kubernetes]: add info about hostPID for Universal Profiling #10173

merged 1 commit into from
Sep 26, 2025
+72 −0

Conversation

@florianl
Copy link
Member

@florianl florianl commented Sep 26, 2025

What does this PR do?

#4081 removed hostPID. Add comment that this setting is essential for Universal Profiling.

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...
@florianl
[deploy/kubernetes]: add info about hostPID for Universal Profiling
fb226e3 
#4081 removed hostPID. Add comment that this setting is essential for Universal Profiling. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl requested a review from a team as a code owner September 26, 2025 12:41
@florianl florianl added bug Something isn't working backport-9.0 Automated backport to the 9.0 branch labels Sep 26, 2025
@florianl florianl added the backport-9.1 Automated backport to the 9.1 branch label Sep 26, 2025
rubenruizdegauna
rubenruizdegauna approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@florianl florianl enabled auto-merge (squash) September 26, 2025 12:45
@ty-elastic
Copy link

ty-elastic commented Sep 26, 2025 •
edited
Loading

As a side note, I think hostPID=true is -also- required for the System Integration to collect process metrics on k8s. without this setting, I think the System Integration (running in Agent in daemonset) would -only- see other processes in the daemonset, not on the host at large, which also seems problematic.
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Sep 26, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube
@florianl florianl merged commit 6cd7ffc into main Sep 26, 2025
30 checks passed
@florianl florianl deleted the up-k8s-manifest-hostPID branch September 26, 2025 14:47
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 26, 2025

💚 Build Succeeded

cc @florianl
mergify bot pushed a commit that referenced this pull request Sep 26, 2025
@florianl @mergify
[deploy/kubernetes]: add info about hostPID for Universal Profiling (#…
c51aaae 
…10173) #4081 removed hostPID. Add comment that this setting is essential for Universal Profiling. Signed-off-by: Florian Lehner <florian.lehner@elastic.co> (cherry picked from commit 6cd7ffc)
mergify bot pushed a commit that referenced this pull request Sep 26, 2025
@florianl @mergify
[deploy/kubernetes]: add info about hostPID for Universal Profiling (#…
b51cd55 
…10173) #4081 removed hostPID. Add comment that this setting is essential for Universal Profiling. Signed-off-by: Florian Lehner <florian.lehner@elastic.co> (cherry picked from commit 6cd7ffc)
This was referenced Sep 26, 2025
Merged
Merged
v1v added a commit that referenced this pull request Sep 26, 2025
@v1v
Merge remote-tracking branch 'upstream' into test/gh-runners-macos
517a15e 
* upstream: (505 commits) Update journald tests now that Filebeat supports watching folders (#10131) [deploy/kubernetes]: add info about hostPID for Universal Profiling (#10173) Fall back to process runtime if otel runtime is unsupported (#10087) Conditionall check for ms_tls13kdf build tag (#10160) [docs][edot] add entry for profiles (#10163) edot/docs: add support for profiles (#10146) Add Logstash exporter (#10137) Add back publish to serverless. (#10159) Improve Integration test documentation (#10155) Fix multiarch service image push from main to serverless (#10129) Forward migrate action to endpoint (#9801) Comment out check for ms_tls13kdf tag for FIPS-capable binaries (#10148) [otel] add receivers: apache, iis, mysql, postgresql, sqlserver v0.135.0 (#9344) Add k8sevents receiver in kube-stack (#10086) feat: emit system resource metrics for EDOT subprocess (#10003) [AutoOps] Configure OTel Exporter to Send Maximum-sized Batches (#10126) keep enrollment token when replacing data with signed (#10115) Revert "Publish `elastic-agent-service` container directly to serverless from main (#9583)" (#10127) Add agent_policy_id and policy_revision_idx to checkin requests (#9931) remove resource/k8s processor and use k8sattributes processor for service attributes (#10108) ...
florianl added a commit that referenced this pull request Sep 26, 2025
@mergify @florianl
[deploy/kubernetes]: add info about hostPID for Universal Profiling (#…
f3df1cc 
…10173) (#10175) #4081 removed hostPID. Add comment that this setting is essential for Universal Profiling. (cherry picked from commit 6cd7ffc) Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
florianl added a commit that referenced this pull request Sep 26, 2025
@mergify @florianl
[deploy/kubernetes]: add info about hostPID for Universal Profiling (#…
bbd33b2 
…10173) (#10176) #4081 removed hostPID. Add comment that this setting is essential for Universal Profiling. (cherry picked from commit 6cd7ffc) Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-9.0 Automated backport to the 9.0 branch backport-9.1 Automated backport to the 9.1 branch bug Something isn't working

6 participants

@florianl @ty-elastic @elasticmachine @rubenruizdegauna @christos68k