Skip to content

fix: take into account units state on liveness #10060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2025
Merged

fix: take into account units state on liveness #10060

merged 3 commits into from
Sep 23, 2025

Conversation

@rubenruizdegauna
Copy link
Member

What does this PR do?

This PR adds the check of the component's unit's state on liveness endpoint. If a component state is healthy, but a unit state is degraded or failed, the liveness endpoint will return a 500.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

Liveness probes will now fail if a component state is healthy but any of the units is failed or degraded, likely causing the container to be restarted (see https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#liveness-probe).

Related issues
@rubenruizdegauna rubenruizdegauna requested a review from a team as a code owner September 19, 2025 13:19
@rubenruizdegauna rubenruizdegauna added bug Something isn't working backport-active-all Automated backport with mergify to all the active branches labels Sep 19, 2025
@cmacknz cmacknz added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Sep 19, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)
@rubenruizdegauna rubenruizdegauna mentioned this pull request Sep 19, 2025
Closed
blakerouse
blakerouse requested changes Sep 19, 2025
View reviewed changes
@rubenruizdegauna rubenruizdegauna force-pushed the fix/liveness_units branch 3 times, most recently from 35af5b5 to 315fb34 Compare September 22, 2025 08:04
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @rubenruizdegauna
blakerouse
blakerouse approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the loop. Looks good.
@rubenruizdegauna rubenruizdegauna merged commit 4b818a1 into elastic:main Sep 23, 2025
23 checks passed
@github-actions
Copy link
Contributor

@Mergifyio backport 8.18 8.19 9.0 9.1
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2025 •
edited
Loading

backport 8.18 8.19 9.0 9.1

✅ Backports have been created
mergify bot pushed a commit that referenced this pull request Sep 23, 2025
@rubenruizdegauna @mergify
fix: take into account units state on liveness (#10060)
a9b36b1 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1)
@mergify mergify bot mentioned this pull request Sep 23, 2025
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Sep 23, 2025
@rubenruizdegauna @mergify
fix: take into account units state on liveness (#10060)
155da72 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1)
@mergify mergify bot mentioned this pull request Sep 23, 2025
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Sep 23, 2025
@rubenruizdegauna @mergify
fix: take into account units state on liveness (#10060)
78b49ec 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1)
@mergify mergify bot mentioned this pull request Sep 23, 2025
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Sep 23, 2025
@rubenruizdegauna @mergify
fix: take into account units state on liveness (#10060)
b59733a 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1)
@mergify mergify bot mentioned this pull request Sep 23, 2025
Merged
8 tasks
rubenruizdegauna added a commit that referenced this pull request Sep 23, 2025
@rubenruizdegauna
fix: take into account units state on liveness (#10060)
fe9baea 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1)
rubenruizdegauna added a commit that referenced this pull request Sep 23, 2025
@rubenruizdegauna
fix: take into account units state on liveness (#10060)
c37c679 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1)
rubenruizdegauna added a commit that referenced this pull request Sep 23, 2025
@mergify @rubenruizdegauna
fix: take into account units state on liveness (#10060) (#10100)
e31e041 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1) Co-authored-by: Ruben Ruiz de Gauna <rubenruizdegauna@proton.me>
rubenruizdegauna added a commit that referenced this pull request Sep 23, 2025
@rubenruizdegauna
fix: take into account units state on liveness (#10060)
b56972a 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1)
rubenruizdegauna added a commit that referenced this pull request Sep 23, 2025
@mergify @rubenruizdegauna
fix: take into account units state on liveness (#10060) (#10099)
3d01f68 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1) Co-authored-by: Ruben Ruiz de Gauna <rubenruizdegauna@proton.me>
rubenruizdegauna added a commit that referenced this pull request Sep 23, 2025
@mergify @rubenruizdegauna
fix: take into account units state on liveness (#10060) (#10102)
38cef27 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1) Co-authored-by: Ruben Ruiz de Gauna <rubenruizdegauna@proton.me>
rubenruizdegauna added a commit that referenced this pull request Sep 23, 2025
@mergify @rubenruizdegauna
fix: take into account units state on liveness (#10060) (#10101)
cc9e1c2 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration (cherry picked from commit 4b818a1) Co-authored-by: Ruben Ruiz de Gauna <rubenruizdegauna@proton.me>
intxgo pushed a commit to intxgo/elastic-agent that referenced this pull request Sep 24, 2025
@rubenruizdegauna @intxgo
fix: take into account units state on liveness (elastic#10060)
ccb3c50 
* fix: take into account units state on liveness * extract check components state to helper * merge conditional assignment into variable declaration
@rubenruizdegauna rubenruizdegauna deleted the fix/liveness_units branch October 6, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

4 participants

@rubenruizdegauna @elasticmachine @blakerouse @cmacknz