Don't de-dot ecs.version #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
xrmx commented Jun 12, 2024
| value = extractors[field](record) | ||
| if value is not None: | ||
| merge_dicts(de_dot(field, value), result) | ||
| # special case ecs.version that should not be de-dotted |
There was a problem hiding this comment.
It looks like log.level survives de_dot without special cases apparently but I can't see where it gets a different treatment than the rest
basepi approved these changes Jun 12, 2024
| value = extractors[field](record) | ||
| if value is not None: | ||
| merge_dicts(de_dot(field, value), result) | ||
| # special case ecs.version that should not be de-dotted |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While at it test on modern python versions.
Closes #88