Skip to content

Add --config-version flag to instance configuration show command #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

Add --config-version flag to instance configuration show command #669

merged 2 commits into from
Nov 18, 2024

Conversation

@claudia-correia
Copy link
Contributor

@claudia-correia claudia-correia commented Nov 11, 2024 •
edited
Loading

Description

This PR adds the config-version and show-deleted flags to the instance-configuration command, so that's possible to fetch a specific instance configuration version, even if it's marked as deleted.

Related Issues

https://elasticco.atlassian.net/browse/CP-9229

Motivation and Context

We need to be able to fetch specific config versions in order to get the testing version of an IC. We use the testing version when introducing a new IC or updating an existing one, before making the changes public.

How Has This Been Tested?

This has been tested by building ecctl locally and performing some tests against ICs in QA.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
@claudia-correia claudia-correia added the enhancement New feature or request label Nov 11, 2024
@claudia-correia claudia-correia requested review from a team and alaudazzi as code owners November 11, 2024 19:41
gigerdo
gigerdo approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@gigerdo gigerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@claudia-correia claudia-correia merged commit 2a6f80f into elastic:master Nov 18, 2024
3 checks passed
@claudia-correia claudia-correia deleted the add-config-version-to-show-cmd branch November 18, 2024 11:10
claudia-correia added a commit to claudia-correia/ecctl that referenced this pull request Nov 18, 2024
@claudia-correia
Add --config-version flag to instance configuration show command (e…
de780fe 
…lastic#669) * Add config-version to show cmd * Update docs
@claudia-correia claudia-correia mentioned this pull request Nov 18, 2024
Merged
claudia-correia added a commit that referenced this pull request Nov 18, 2024
@claudia-correia
Add --config-version flag to instance configuration show command (#669
5353721 
) (#670) * Add config-version to show cmd * Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

2 participants

@claudia-correia @gigerdo