Skip to content

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented May 5, 2025

TBD on recipes. Most links are not complete and need updating from "???".
Copy link
Member

@PeteGillinElastic PeteGillinElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far! I have one drive-by comment.

@bvader
Copy link

bvader commented May 19, 2025

Hi @jbaiera I noticed a small issue

https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/1368/manage-data/data-store/data-streams/failure-store#use-failure-store

This example

POST my-datastream/_bulk {"create":{}} {"@timestamp": "2025-05-01T00:00:00Z", "id": 1234} {"create":{}} {"@timestamp": "2025-05-01T00:00:00Z", "id": "invalid_text"} 

Should be add the -new (<namespace>) otherwise it does not match the template at the top of the page and thus does not match and thus does not work :)

POST my-datastream-new/_bulk {"create":{}} {"@timestamp": "2025-05-01T00:00:00Z", "id": 1234} {"create":{}} {"@timestamp": "2025-05-01T00:00:00Z", "id": "invalid_text"} 
@dakrone dakrone self-requested a review June 16, 2025 16:59
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some comments, but nothing major. This is a monumental amount of work and I think it's great, thanks Jimmy.

@sabarasaba
Copy link
Member

@dakrone Any chance we might get this before FF for 8.19? We've made some work in the kibana UI and would be great if we can add a link to the docs

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jbaiera! just adding a couple of comments to address the metadata of these pages / improve wayfinding between the pages. also approving to make sure that you're unblocked. let me know if you need a hand with anything.

Copy link

github-actions bot commented Jun 20, 2025

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fix the failing test

rStelmach added a commit to elastic/kibana that referenced this pull request Jun 24, 2025
…ream (#221644) Added a tooltip and a link with documentation for Failed docs column when dataset does not have failure store enabled. https://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e For now it awaits for the documentation PR to be merged : elastic/docs-content#1368 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 24, 2025
…ream (elastic#221644) Added a tooltip and a link with documentation for Failed docs column when dataset does not have failure store enabled. https://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e For now it awaits for the documentation PR to be merged : elastic/docs-content#1368 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co> (cherry picked from commit 36cbbb9)
kibanamachine added a commit to elastic/kibana that referenced this pull request Jun 24, 2025
…data stream (#221644) (#225007) # Backport This will backport the following commits from `main` to `8.19`: - [[Dataset Quality] Indicate if failure store isn't enabled for data stream (#221644)](#221644) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Stelmach","email":"60304951+rStelmach@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-24T07:49:36Z","message":"[Dataset Quality] Indicate if failure store isn't enabled for data stream (#221644)\n\nAdded a tooltip and a link with documentation for Failed docs column\nwhen dataset does not have failure store enabled.\n\n\n\nhttps://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e\n\n\n\n\nFor now it awaits for the documentation PR to be merged :\nhttps://github.com/elastic/docs-content/pull/1368\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Yngrid Coello <yngrid.coello@elastic.co>","sha":"36cbbb9bf8f141a54bb6c455e4479e93990d9626","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","Feature:Dataset Health","backport:version","v9.1.0","v8.19.0"],"title":"[Dataset Quality] Indicate if failure store isn't enabled for data stream","number":221644,"url":"https://github.com/elastic/kibana/pull/221644","mergeCommit":{"message":"[Dataset Quality] Indicate if failure store isn't enabled for data stream (#221644)\n\nAdded a tooltip and a link with documentation for Failed docs column\nwhen dataset does not have failure store enabled.\n\n\n\nhttps://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e\n\n\n\n\nFor now it awaits for the documentation PR to be merged :\nhttps://github.com/elastic/docs-content/pull/1368\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Yngrid Coello <yngrid.coello@elastic.co>","sha":"36cbbb9bf8f141a54bb6c455e4479e93990d9626"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221644","number":221644,"mergeCommit":{"message":"[Dataset Quality] Indicate if failure store isn't enabled for data stream (#221644)\n\nAdded a tooltip and a link with documentation for Failed docs column\nwhen dataset does not have failure store enabled.\n\n\n\nhttps://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e\n\n\n\n\nFor now it awaits for the documentation PR to be merged :\nhttps://github.com/elastic/docs-content/pull/1368\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Yngrid Coello <yngrid.coello@elastic.co>","sha":"36cbbb9bf8f141a54bb6c455e4479e93990d9626"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Stelmach <60304951+rStelmach@users.noreply.github.com> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Jun 25, 2025
…ream (elastic#221644) Added a tooltip and a link with documentation for Failed docs column when dataset does not have failure store enabled. https://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e For now it awaits for the documentation PR to be merged : elastic/docs-content#1368 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
jbaiera and others added 4 commits June 25, 2025 15:03
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
Co-authored-by: shainaraskas <shainaraskas@users.noreply.github.com>
@jbaiera jbaiera enabled auto-merge (squash) June 26, 2025 20:48
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing links to anchors to get the PR green

@jbaiera jbaiera merged commit 2dfdbe0 into main Jun 26, 2025
7 of 8 checks passed
@jbaiera jbaiera deleted the failure-store-docs branch June 26, 2025 21:21
@shainaraskas shainaraskas mentioned this pull request Jun 26, 2025
shainaraskas added a commit that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

9 participants