Skip to content

Conversation

@reakaleek reakaleek requested a review from a team as a code owner June 20, 2025 09:15
@github-actions
Copy link

Label error. Requires exactly 1 of: automation, breaking, bug, changelog:skip, chore, ci, dependencies, documentation, enhancement, feature, fix, redesign. Found:

@reakaleek reakaleek marked this pull request as draft June 20, 2025 09:19
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sadly not a long term fix, since the initialization might happen on any test following this pattern which is all.

Its static so that it will be shared amongs every instance of the type. Each [Fact] method will instantiate a new instance of the containing type.

Removing static alone would thus be enough to ensure each gets a non shared instance.

The static/lazy stuff might be a premature optimalization on my end.

@reakaleek reakaleek closed this Jul 7, 2025
@Mpdreamz Mpdreamz deleted the feature/fix-flaky-static-initialization branch July 14, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants