[Rule Tuning] Adjust process.code_signature.trusted condition #5067
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issues
Related to https://github.com/elastic/ia-trade-team/issues/678
Summary
I suggested using
?process.code_signature.trusted != true
in Samir's PR in order to be compatible with S1process.code_signature.trusted
which is only set if true, but it turns out that as the field is optional, this would match any event that doesn't have this field and match the other conditions, causing FPs. This PR address that :awkward-look: