- Notifications
You must be signed in to change notification settings - Fork 603
[Rule Tuning] Remote File Download via PowerShell #5062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
⛔️ Test failed Results
|
"aka.ms", "dot.net", "*.visualstudio.com") and | ||
not user.id == "S-1-5-18" and | ||
/* Filter out NetBIOS/LLMNR-style names (e.g. host, localhost, etc.) */ | ||
dns.question.name : "*.*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't *.*
filter out too much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, every domain has dots
rules/windows/command_and_control_remote_file_copy_powershell.toml Outdated Show resolved Hide resolved
process.name : "powershell.exe" and | ||
(file.extension : ("exe", "dll", "ps1", "bat") or file.Ext.header_bytes : "4d5a*") and | ||
not file.name : "__PSScriptPolicy*.ps1" and | ||
not file.path : ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Users Temp exclusion are too brittle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed this one via Slack, but for other reviewers: I agree, but this one is the best shot we have to exclude some noisy activity without including another event in the sequence start, which would have significant performance problems.
…toml Co-authored-by: Samirbous <64742097+Samirbous@users.noreply.github.com>
⛔️ Test failed Results
|
⛔️ Test failed Results
|
⛔️ Test failed Results
|
Issues
Resolves #4974
Summary
Adjusts the logic to exclude multiple FPs