Skip to content

Conversation

w0rk3r
Copy link
Contributor

@w0rk3r w0rk3r commented Sep 4, 2025

Issues

Resolves #4974

Summary

Adjusts the logic to exclude multiple FPs

@w0rk3r w0rk3r self-assigned this Sep 4, 2025
@w0rk3r w0rk3r added Rule: Tuning tweaking or tuning an existing rule OS: Windows windows related rules Domain: Endpoint backport: auto labels Sep 4, 2025
Copy link
Contributor

github-actions bot commented Sep 4, 2025

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.
@tradebot-elastic
Copy link

tradebot-elastic commented Sep 4, 2025

⛔️ Test failed

Results
  • ❌ Remote File Download via PowerShell (eql)
    • stack_validation_failed: no_alerts - 0 alerts
"aka.ms", "dot.net", "*.visualstudio.com") and
not user.id == "S-1-5-18" and
/* Filter out NetBIOS/LLMNR-style names (e.g. host, localhost, etc.) */
dns.question.name : "*.*"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't *.* filter out too much?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, every domain has dots

process.name : "powershell.exe" and
(file.extension : ("exe", "dll", "ps1", "bat") or file.Ext.header_bytes : "4d5a*") and
not file.name : "__PSScriptPolicy*.ps1" and
not file.path : (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Users Temp exclusion are too brittle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this one via Slack, but for other reviewers: I agree, but this one is the best shot we have to exclude some noisy activity without including another event in the sequence start, which would have significant performance problems.

…toml Co-authored-by: Samirbous <64742097+Samirbous@users.noreply.github.com>
@tradebot-elastic
Copy link

tradebot-elastic commented Sep 5, 2025

⛔️ Test failed

Results
  • ❌ Remote File Download via PowerShell (eql)
    • stack_validation_failed: no_alerts - 0 alerts
@w0rk3r w0rk3r requested a review from Aegrah September 5, 2025 12:32
@tradebot-elastic
Copy link

tradebot-elastic commented Sep 5, 2025

⛔️ Test failed

Results
  • ❌ Remote File Download via PowerShell (eql)
    • stack_validation_failed: no_alerts - 0 alerts
@tradebot-elastic
Copy link

tradebot-elastic commented Sep 8, 2025

⛔️ Test failed

Results
  • ❌ Remote File Download via PowerShell (eql)
    • stack_validation_failed: no_alerts - 0 alerts
@w0rk3r w0rk3r merged commit 6ac7105 into main Sep 8, 2025
12 checks passed
@w0rk3r w0rk3r deleted the rt_3 branch September 8, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport: auto Domain: Endpoint OS: Windows windows related rules Rule: Tuning tweaking or tuning an existing rule

5 participants