- Notifications
You must be signed in to change notification settings - Fork 603
[Rule Tuning] Windows 3rd Party EDR Compatibility - Part 8 #5023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
⛔️ Test failed Results
|
updated_date = "2025/03/20" | ||
updated_date = "2025/08/26" | ||
| ||
[rule] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this rule looks like a dup of https://github.com/elastic/detection-rules/blob/fbfc696a86d3ec826fbd13fb8957d294f155dc17/rules/windows/defense_evasion_network_connection_from_windows_binary.toml and we need to fix rules scope duplicate unless its justified by having multi-versions to support different datasources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that both existed since the beginning of the repo, but yeah, there is definitely a lot of overlap. I'll take a look at this outside this PR and probably deprecate this one. +1 to my todo
rules/windows/defense_evasion_wdac_policy_by_unusual_process.toml Outdated Show resolved Hide resolved
rules/windows/defense_evasion_wdac_policy_by_unusual_process.toml Outdated Show resolved Hide resolved
Co-authored-by: Samirbous <64742097+Samirbous@users.noreply.github.com>
⛔️ Test failed Results
|
⛔️ Test failed Results
|
"\\Device\\HarddiskVolume*\\Windows\\System32\\CodeIntegrity\\*.p7b", | ||
"\\Device\\HarddiskVolume*\\Windows\\System32\\CodeIntegrity\\CiPolicies\\Active\\*.cip" | ||
) and | ||
not process.executable : ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe ignore trusted install worker here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review these rules for tunings as part of https://github.com/elastic/ia-trade-team/issues/619
⛔️ Test failed Results
|
Issue
Related (but not limited) to https://github.com/elastic/ia-trade-team/issues/498
Summary
This PR is part of a series that adds compatibility for additional data sources, including CrowdStrike, SentinelOne, Microsoft Defender for Endpoint, Endgame, and Sysmon.
To review this PR, you can use the EDR Field Compatibility Matrix, which details field compatibility for each event.category across EDR data sources.
Some changes go beyond metadata and include logic updates to optimize, simplify, or account for differences between data sources (For example, CrowdStrike uses NT Object paths for Windows paths instead of drive letters.). Please review these cases with extra attention, and don’t hesitate to ask questions.