Skip to content

Conversation

Aegrah
Copy link
Contributor

@Aegrah Aegrah commented Jul 14, 2025

Summary

Based on a customer request in #4902, I updated the query to also detect creation events. I am unsure why this was not in the rule in the first place.

Additionally, I removed the new_terms aspect of the rule, as this is behavior that should be detected at all times.

This will close out #4902.

Copy link
Contributor

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.
@tradebot-elastic
Copy link

tradebot-elastic commented Jul 14, 2025

⛔️ Test failed

Results
  • ❌ Sudoers File Modification (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
@Aegrah Aegrah changed the title Sudoers file modification tuning [Rule Tuning] Sudoers File Modification Jul 14, 2025
@tradebot-elastic
Copy link

tradebot-elastic commented Jul 16, 2025

⛔️ Test failed

Results
@Aegrah Aegrah merged commit 0d04f98 into main Jul 16, 2025
12 checks passed
@Aegrah Aegrah deleted the sudoers-file-modification-tuning branch July 16, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants