[Rule Tuning] Replace legacy winlog.api usage

[w0rk3r]

Issue

Resolves an issue identified when doing the release prep, where a field we were relying to bypass host.os.type checks don't seems to exist anymore in the beats schema for 9.x.

Summary

TL;DR: Removes a legacy condition used to bypass a test, replaces with the expected condition that matches the test.

As a bit of context, in order to make rules compatible with Forwarded Logs (#2761), in the past, we had to remove the host.os.type condition as it was not populated by the Windows integration at the time, which is fixed by: elastic/integrations#9369. in rules that weren't querying any winlog.* field, we added a condition that would match across all data sources: winlog.api:"wineventlog", which we don't need anymore.

2023 slack thread: https://elastic.slack.com/archives/C02USDK55AQ/p1682597534524189?thread_ts=1682456035.699049&cid=C02USDK55AQ

[github-actions]

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

• Detailed description of the suggested changes.
• Provide example JSON data or screenshots.
• Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
• Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
• Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
• Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
• Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
• Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
• Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
• Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
• Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
• Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

• updated_date matches the date of tuning PR merged.
• min_stack_version should support the widest stack versions.
• name and description should be descriptive and not include typos.
• query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

• Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
• Ensure that the tuned rule has a low false positive rate.

[tradebot-elastic]

⛔️ Test failed

Results

• ❌ Windows User Account Creation (kuery)
  • coverage_issue: no_rta
  • stack_validation_failed: no_rta
• ❌ Windows Event Logs Cleared (kuery)
  • coverage_issue: no_rta
  • stack_validation_failed: no_rta
• ❌ User Added to Privileged Group (eql)
  • coverage_issue: no_rta
  • stack_validation_failed: no_rta
• ❌ Active Directory Group Modification by SYSTEM (eql)
  • coverage_issue: no_rta
  • stack_validation_failed: no_rta

[Mikaayenson]

Thank you!

[tradebot-elastic]

⛔️ Test failed

Results

• ❌ Windows User Account Creation (kuery)
  • coverage_issue: no_rta
  • stack_validation_failed: no_rta
• ❌ Windows Event Logs Cleared (kuery)
  • coverage_issue: no_rta
  • stack_validation_failed: no_rta
• ❌ User Added to Privileged Group (eql)
  • coverage_issue: no_rta
  • stack_validation_failed: no_rta
• ❌ Active Directory Group Modification by SYSTEM (eql)
  • coverage_issue: no_rta
  • stack_validation_failed: no_rta