[Rule Tuning] Port Scan Rules #4443
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
These rules have been tuned several times, and in one tuning, I bricked the rule logic:
Through community slack, concerns about this rule were presented:
This PR addresses these issues by:
network_flow
event.action
field to ensure flow data captured by the NPC is used to trigger the rule. I kept PANW integration, as I checked rules such as this, which seem to be compatible with the sameevent.action
. I don't have a dataset to test this with myself, however.