Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

Lock versions for releases: 8.12,8.13,8.14,8.15,8.16,8.17.

  • Autogenerated from job lock-versions: pr.
Copy link
Contributor

@shashank-elastic shashank-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified previous double bumps for PowerShell Script with Discovery Capabilities, PowerShell Script with Remote Execution Capabilities via WinRM, PowerShell Script with Windows Defender Tampering Capabilities is now rectified

@shashank-elastic shashank-elastic added the enhancement New feature or request label Jan 21, 2025
Copy link
Contributor Author

Enhancement - Guidelines

These guidelines serve as a reminder set of considerations when addressing adding a feature to the code.

Documentation and Context

  • Describe the feature enhancement in detail (alternative solutions, description of the solution, etc.) if not already documented in an issue.
  • Include additional context or screenshots.
  • Ensure the enhancement includes necessary updates to the documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Code changes do not introduce new warnings or errors.
  • Variables and functions are well-named and descriptive.
  • Any unnecessary / commented-out code is removed.
  • Ensure that the code is modular and reusable where applicable.
  • Check for proper exception handling and messaging.

Testing

  • New unit tests have been added to cover the enhancement.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and validating the enhancement (e.g., test logs, screenshots).
  • Validate that any rules affected by the enhancement are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.

Additional Checks

  • Ensure that the enhancement does not break existing functionality.
  • Review the enhancement with a peer or team member for additional insights.
  • Verify that the enhancement works across all relevant environments (e.g., different OS versions).
  • Confirm that all dependencies are up-to-date and compatible with the changes.
  • Confirm that the proper version label is applied to the PR patch, minor, major.
@shashank-elastic shashank-elastic merged commit 8093655 into main Jan 21, 2025
18 of 19 checks passed
@shashank-elastic shashank-elastic deleted the version-lock-9b8b91759 branch January 21, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants