[Bug] [DaC] Actions Connector Defaults to None #4376
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s): #4375
Summary - What I changed
When specifying an actions connector for Kibana export rules, the value is not used and is not honored. Instead it is set to none, this should be set to the incoming parameter if the parameter is available otherwise it should be none.
How To Test
Use the export rules command while not having an action connector directory set in your config file, but instead have it passed via the CLI.
python -m detection_rules kibana --space customer --ignore-ssl-errors true export-rules -d demo/rules/ -sv -ac -acd dac_test/action_connectors/
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist