- Notifications
You must be signed in to change notification settings - Fork 603
[New Rule] Adding Coverage for Self-Created Login Profile for Root Accounts in AWS #4277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Rule: New - GuidelinesThese guidelines serve as a reminder set of considerations when proposing a new rule. Documentation and Context
Rule Metadata Checks
New BBR Rules
Testing and Validation
|
Aegrah approved these changes Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rules/integrations/aws/persistence_iam_create_login_profile_for_root.toml Show resolved Hide resolved
shashank-elastic approved these changes Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto Domain: Cloud Workloads Integration: AWS AWS related rules Rule: New Proposal for new rule
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Summary - What I changed
Added detection coverage for self-created login profile's for Root member accounts in AWS. By default, management root accounts are given a login profile when the AWS org is setup, however, if centralized management is enabled in AWS, member root accounts are not given login profiles by default.
Additional Information:
To avoid potential false-positives and anomaly detection, below was added to the query.
aws.cloudtrail.user_identity.type == Root
--> Ensures that the user attempting to create the login profile is a Root account.aws.cloudtrail.user_identity.access_key_id IS NOT NULL
--> Ensures that the action was done with an access key and programmatically, which is likely for compromised credentialsNOT TO_LOWER(aws.cloudtrail.request_parameters) LIKE "*username*"
--> Ensures that the username parameter was not passed in thecreate_login_profile()
request, which then uses the authenticated session of the existing user.There is an existing BBR rule for
CreateLoginProfile
action as this API event is not uncommon, except for the context of this new rule. I chose not to change the BBR rule for this detection logic as it is very specific and if done so, may lead to false-negatives. --> https://github.com/elastic/detection-rules/blob/main/rules_building_block/persistence_aws_iam_login_profile_added_to_user.tomlHow To Test
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist