Skip to content

Conversation

terrancedejesus
Copy link
Contributor

@terrancedejesus terrancedejesus commented Dec 2, 2024

Pull Request

Issue link(s):

Summary - What I changed

Added detection coverage for self-created login profile's for Root member accounts in AWS. By default, management root accounts are given a login profile when the AWS org is setup, however, if centralized management is enabled in AWS, member root accounts are not given login profiles by default.

Additional Information:
To avoid potential false-positives and anomaly detection, below was added to the query.

  • aws.cloudtrail.user_identity.type == Root --> Ensures that the user attempting to create the login profile is a Root account.
  • aws.cloudtrail.user_identity.access_key_id IS NOT NULL --> Ensures that the action was done with an access key and programmatically, which is likely for compromised credentials
  • NOT TO_LOWER(aws.cloudtrail.request_parameters) LIKE "*username*" --> Ensures that the username parameter was not passed in the create_login_profile() request, which then uses the authenticated session of the existing user.

There is an existing BBR rule for CreateLoginProfile action as this API event is not uncommon, except for the context of this new rule. I chose not to change the BBR rule for this detection logic as it is very specific and if done so, may lead to false-negatives. --> https://github.com/elastic/detection-rules/blob/main/rules_building_block/persistence_aws_iam_login_profile_added_to_user.toml

How To Test

Screenshot 2024-12-02 at 10 36 47 PM

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@terrancedejesus terrancedejesus self-assigned this Dec 2, 2024
@protectionsmachine
Copy link
Collaborator

Rule: New - Guidelines

These guidelines serve as a reminder set of considerations when proposing a new rule.

Documentation and Context

  • Detailed description of the rule.
  • List any new fields required in ECS/data sources.
  • Link related issues or PRs.
  • Include references.

Rule Metadata Checks

  • creation_date matches the date of creation PR initially merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive, considering performance for diverse environments. Non ecs fields should be added to non-ecs-schema.json if not available in an integration.
  • min_stack_comments and min_stack_version should be included if the rule is only compatible starting from a specific stack version.
  • index pattern should be neither too specific nor too vague, ensuring it accurately matches the relevant data stream (e.g., use logs-endpoint.process-* for process data).
  • integration should align with the index. If the integration is newly introduced, ensure the manifest, schemas, and new_rule.yaml template are updated.
  • setup should include the necessary steps to configure the integration.
  • note should include any additional information (e.g. Triage and analysis investigation guides, timeline templates).
  • tags should be relevant to the threat and align/added to the EXPECTED_RULE_TAGS in the definitions.py file.
  • threat, techniques, and subtechniques should map to ATT&CK always if possible.

New BBR Rules

  • building_block_type should be included if the rule is a building block and the rule should be located in the rules_building_block folder.
  • bypass_bbr_timing should be included if adding custom lookback timing to the rule.

Testing and Validation

  • Provide evidence of testing and detecting the expected threat.
  • Check for existence of coverage to prevent duplication.
@terrancedejesus terrancedejesus changed the title [New Rule] Adding Coverage for Self-Create Login Profile for Root Accounts in AWS [New Rule] Adding Coverage for Self-Created Login Profile for Root Accounts in AWS Dec 3, 2024
@terrancedejesus terrancedejesus marked this pull request as ready for review December 3, 2024 06:47
Copy link
Contributor

@Aegrah Aegrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@terrancedejesus terrancedejesus merged commit e7b88ae into main Dec 9, 2024
9 checks passed
@terrancedejesus terrancedejesus deleted the new-rule-create-login-profile-root branch December 9, 2024 13:55
protectionsmachine pushed a commit that referenced this pull request Dec 9, 2024
…counts in AWS (#4277) * new rule 'AWS IAM Login Profile Added for Root' * added min-stack * linted; fixed rule schema errors --------- Co-authored-by: shashank-elastic <91139415+shashank-elastic@users.noreply.github.com> (cherry picked from commit e7b88ae)
protectionsmachine pushed a commit that referenced this pull request Dec 9, 2024
…counts in AWS (#4277) * new rule 'AWS IAM Login Profile Added for Root' * added min-stack * linted; fixed rule schema errors --------- Co-authored-by: shashank-elastic <91139415+shashank-elastic@users.noreply.github.com> (cherry picked from commit e7b88ae)
protectionsmachine pushed a commit that referenced this pull request Dec 9, 2024
…counts in AWS (#4277) * new rule 'AWS IAM Login Profile Added for Root' * added min-stack * linted; fixed rule schema errors --------- Co-authored-by: shashank-elastic <91139415+shashank-elastic@users.noreply.github.com> (cherry picked from commit e7b88ae)
protectionsmachine pushed a commit that referenced this pull request Dec 9, 2024
…counts in AWS (#4277) * new rule 'AWS IAM Login Profile Added for Root' * added min-stack * linted; fixed rule schema errors --------- Co-authored-by: shashank-elastic <91139415+shashank-elastic@users.noreply.github.com> (cherry picked from commit e7b88ae)
protectionsmachine pushed a commit that referenced this pull request Dec 9, 2024
…counts in AWS (#4277) * new rule 'AWS IAM Login Profile Added for Root' * added min-stack * linted; fixed rule schema errors --------- Co-authored-by: shashank-elastic <91139415+shashank-elastic@users.noreply.github.com> (cherry picked from commit e7b88ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants