[APM] Remove old get-started and server docs #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Only one obstacle I can think of here: is it possible that there are links to the old path (from Kibana or other docs)? If so, when you remove these files, you'll break the doc build. That seems very unlikely, though, since the new path was removed fairly quickly and our shared attributes file takes care of paths. I'll approve and you can decide what to do. I think merge it and we can always revert then clean up links, in the unlikely event that they break. |
dedemorton approved these changes Dec 21, 2021
| That's a good point. I think we're safe, but I'll revert if something breaks. I'm optimistic we'll be OK since these files haven't existed for long. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
elastic/docs#2309 incorrectly moved APM docs from
elastic.co/guide/en/apm/*toelastic.co/guide/*. This was fixed in elastic/docs#2324.built-docsdoesn't automatically pick up this change, so the files atelastic.co/guideneed to be deleted manually. This PR deletes all files inhtml/server/*andhtml/get-started/*. These files correspond to the APM docs here and here.