Skip to content

Conversation

AlexanderWert
Copy link
Member

@AlexanderWert AlexanderWert commented Feb 24, 2022

Description

  • With a mapping model of N:1 between lambda functions and an APM service in Elastic, we cannot rely on the service.name to represent the function name.
  • Though faas.id contains the ARN of the function and with that also the function name in one of the segments, it's only an implicit assumption that is only true for AWS Lambda (but potentially not for other serverless functions, e.g. Azure functions, GCP functions). Thus, it's reasonable to capture the function name explicitly in a new field faas.name.
  • Same with faas.version

This is a small enhancement

  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Merge after 2 business days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.
@AlexanderWert AlexanderWert requested review from a team as code owners February 24, 2022 09:31
@ghost
Copy link

ghost commented Feb 24, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-25T05:13:00.841+0000

  • Duration: 3 min 13 sec

Copy link

@akhileshpok akhileshpok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alex,

This looks like a good improvement! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants