Skip to content

Update the Lambda metadata fields that cannot be collected until first invocation #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2022
Merged

Update the Lambda metadata fields that cannot be collected until first invocation #592

merged 2 commits into from
Feb 17, 2022

Conversation

@trentm
Copy link
Member

@trentm trentm commented Feb 14, 2022 •
edited
Loading

This updates a small note in the Lambda spec due to metadata spec changes in #579.

This is a small enhancement

  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Merge after 2 business days passed without objections
@trentm trentm requested a review from AlexanderWert February 14, 2022 18:27
@trentm trentm self-assigned this Feb 14, 2022
@ghost
Copy link

ghost commented Feb 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-14T18:27:53.737+0000

  • Duration: 10 min 34 sec
@trentm trentm marked this pull request as ready for review February 15, 2022 17:35
@trentm trentm requested review from a team as code owners February 15, 2022 17:35
@trentm trentm removed request for a team February 15, 2022 17:36
eyalkoren
eyalkoren approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor proposal based on the updated spec
@trentm @eyalkoren
missed faas.id is from invokedFunctionArn, as well
ae44ad8 
Co-authored-by: eyalkoren <41850454+eyalkoren@users.noreply.github.com>
@trentm trentm merged commit 6d58085 into main Feb 17, 2022
@ghost
Copy link

ghost commented Feb 17, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-17T18:02:52.601+0000

  • Duration: 5 min 33 sec
@trentm trentm deleted the trentm/lambda-clarifications branch February 17, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@trentm @basepi @AlexanderWert @eyalkoren