Refine span.name and specify span.action for SNS #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
trentm reviewed Jul 29, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
Co-authored-by: Trent Mick <trentm@gmail.com>
trentm reviewed Jul 29, 2021
Co-authored-by: Trent Mick <trentm@gmail.com>
trentm approved these changes Jul 29, 2021
5 tasks
basepi approved these changes Aug 2, 2021
| Last call for objections. I'd like to merge this in the next day or so. |
trentm changed the title trentm added a commit to trentm/apm that referenced this pull request Oct 6, 2021
Co-authored-by: Trent Mick <trent.mick@elastic.co>
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replaces #421
Please refer to that PR for the discussion history.
status
The other agents had not yet implemented SNS instrumentation so are governed by #408