feat(rum): force minor version bump rum package #1402
Conversation
vigneshshanmugam left a comment
vigneshshanmugam left a comment There was a problem hiding this comment.
Not sure if this was the case before and how lerna works.
I would confirm again as this would be generated in release notes and we have done so many releases in the past where we did not need this back.
| I believe that having In the past, we have many examples where we released features having only a bump of the patch version. A few examples: https://www.elastic.co/guide/en/apm/agent/rum-js/current/release-notes-5.x.html#release-notes-5.11.1 I believe our users should see a minor version when this happens. (I know, it's not a serious big deal, but I believe we should follow semantic versioning as far as possible) With this, we will make sure the version will be 5.14.0 and also will create the proper tag (already confirmed with dry-run) This will be the released versions: |
Context
Lerna will not bump the minor version of a package if there are no files modified within that specific package, even if the commit contain "feat(specific-package)"
That is understandable from a technical standpoint but not from a user standpoint, at least in the case of rum-core and rum
The upcoming release among other things will contain a new feature (the redirect span). The logic modified belongs to rum-core, so it's generating a minor bump in the package rum-core, but not in the one that users will download (apm-rum), so instead of 5.13.1 as it was generating it should create 5.14.0. to clearly highlight that contains a new feature.
Needless to say that it wasn't the end of the world, in the past we have done releases without taking that into consideration. Despite that, I believe we should start being more mindful of semantic versioning.
Changes
A dummy commit within the package rum, to force the minor versioning bump
cc: @vigneshshanmugam