- Notifications
You must be signed in to change notification settings - Fork 146
feat(rum): disable beacon compression when flag is set #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundlesize report
|
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with pending comments.
| Hi @bmorelli25, The change made in this PR will require changes in the RUM documentation. Discussing this with @vigneshshanmugam yesterday we agreed that making the change in the troubleshooting section it might be the best choice. What are your thoughts of this proposal? Thank you! |
docs/troubleshooting.asciidoc Outdated
| [[disable-events-payload-compression]] | ||
| === Disable events payload compression | ||
| | ||
| In browsers such as Chrome the payload of the events sent by the RUM JS agent is being compressed with gzip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reword this a bit differently, I will leave it to @bmorelli25 to comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping! Here are a few comments.
| Thanks for all the suggestions @bmorelli25. Changes applied! :elasticheart: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs LGTM
Context
In the past it has been common to find the situation where we needed a HAR file to investigate issues of a support case.
Most of the time the HAR files provided were not showing the payload of the events sent by the RUM agent. That was happening because they were generated in Chrome. That browser supports Compression Streams API which it is being used by the agent to compress events payload. Although it would be possible to generate them with a browser such as Firefox, we have found that in particular cases that wasn't a viable option for support.
Because of that, in a conversation with @vigneshshanmugam we agreed to provide a way of disabling payload compression for such scenarios.
What the PR is doing
Disables the payload compression:
_elastic_inspect_beacon_exists insessionStorage._elastic_inspect_beacon_. E.g.https://elastic.co?_elastic_inspect_beacon_(this creates the item in sessionStorage automatically)The scenario 2 covers the case where support is not directly creating the HAR and instead explaining to a customer how to do it. The way I see it, to add
?_elastic_inspect_beacon_to a URL is much simpler than creating a sessionStorage item manually.demo
disable_compression_creating_item.mov
disable_compression_with_query_param.mov
Pending task: