Fix jruby docker images #1367

reakaleek · 2023-02-20T14:27:26Z

Details

jruby docker image building is failing silently for an unknown time already.

This PR fixes building the docker images and exits with the correct exit codes.

Context

To run CI checks you need to do a docker login because the tests are utilising docker images hosted in docker.elastic.co/observability-ci.

However, in GH workflows created from forked PRs, we cannot access secrets.

While trying to publish the images in docker hub, I noticed that the images are failing.

How to test

Run following script. Modify Dockerfile or tests to get an error exit code.

cd .ci/docker/jruby export EXCLUDE=7-jdk ./run.sh --action build --registry 'elasticobservability123' echo $? ./run.sh --action test --registry 'elasticobservability123' echo $?

⚠️ This only works on amd64 machines.

Related Issues

Migrate Jenkinsfile 2 GH Actions Workflow #1366

ghost · 2023-02-20T14:50:50Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-03-08T09:38:52.986+0000
Duration: 19 min 29 sec

Test stats 🧪

Test	Results
Failed	0
Passed	43609
Skipped	77
Total	43686

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
run benchmark tests : Run the benchmark test.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

reakaleek · 2023-02-20T15:52:07Z

Hi @estolfo,

I was able to make the docker building work for most images, but not for 7-jdk.
Since I saw some commits from you here and there, I was hoping that you can help me here.

This is the actual error message I get when running:

$ docker build -t test -f .ci/docker/jruby/7-jdk/Dockerfile . ... => ERROR [5/8] RUN gem install bundler rake net-telnet xmlrpc tzinfo-data 0.5s ------ > [5/8] RUN gem install bundler rake net-telnet xmlrpc tzinfo-data: #0 0.429 Exception in thread "main" java.lang.UnsupportedClassVersionError: org/jruby/Main : Unsupported major.minor version 52.0 #0 0.432	at java.lang.ClassLoader.findBootstrapClass(Native Method) #0 0.433	at java.lang.ClassLoader.findBootstrapClassOrNull(ClassLoader.java:1078) #0 0.433	at java.lang.ClassLoader.loadClass(ClassLoader.java:419) #0 0.434	at java.lang.ClassLoader.loadClass(ClassLoader.java:417) #0 0.435	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:323) #0 0.436	at java.lang.ClassLoader.loadClass(ClassLoader.java:363) #0 0.436	at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:482)

cc @elastic/apm-agent-ruby, @elastic/observablt-ci

ghost · 2023-02-20T16:01:04Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`1/1`)	💚
Files	99.237% (`130/131`)	👍
Classes	99.237% (`130/131`)	👍
Lines	57.1% (`2469/4324`)	👍
Conditionals	100.0% (`0/0`)	💚

v1v · 2023-02-20T17:51:55Z

#0 0.429 Exception in thread "main" java.lang.UnsupportedClassVersionError: org/jruby/Main : Unsupported major.minor version 52.0

That's likely related to the unmatch version in the current JDK and the version required by JRuby, in other words, jruby might require a higher JDK version.

I'd say to remove the support for jdk7 since it reached EOL summer last year as per https://blogs.oracle.com/java/post/java-se-7-end-of-extended-support-in-july-2022

Though, I don't know if that's something feasible from the support matrix, otherwise, we can remove the docker build generation for jruby-jdk7, but still be used for running the tests in the support matrix

.ci/docker/jruby/test.sh

v1v

LGTM, but a comment regarding the assertion

.ci/docker/jruby/run.sh

.ci/docker/jruby/test.sh

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

estolfo · 2023-03-09T08:54:33Z

hi @reakaleek I'm sorry I missed responding to your messages 2 weeks ago.
I don't follow these changes so well but did you do what @v1v suggested: remove docker build generation for jdk7?

reakaleek · 2023-03-09T08:55:50Z

.ci/docker/jruby/run.sh

+set -o pipefail
+
+# 7-jdk is excluded by default. See https://github.com/elastic/apm-agent-ruby/pull/1367#issuecomment-1437228929
+EXCLUDE=("7-jdk")


@estolfo regarding your question in #1367 (comment)

I did not remove it, but I excluded it by default.

Ok, so does that mean the test matrix will continue to use the last created jdk7 docker image?

Yes, the docker image is kept in the docker registry and can still be used for tests.

perfect, thanks for the explanation. LGTM then

* elastic/main: (30 commits) docs: remove kibana endpoint (elastic#1381) Update status badge (elastic#1379) Create single status check that can be set as required (elastic#1378) Remove jenkins related precommit hooks (elastic#1380) Migrate Jenkinsfile 2 GH Actions Workflow (elastic#1366) Migrate update specs to updatecli (elastic#1375) v4.6.2 Fixing Faraday::RackBuilder::StackLocked (elastic#1371) Fix jruby docker images (elastic#1367) Update reference to sinatra main (elastic#1373) Update release:update_branch task to reference branch 4.x Add missing docs reference v4.6.1 Add security options to docker containers (elastic#1356) Make sure http status code is set when Faraday Middleware is used (elastic#1368) Use composite action for updatecli workflow (elastic#1365) Fix sha source in updatecli update-specs.yml (elastic#1363) Add update-specs updatecli workflow (elastic#1359) use jruby user to run docker containers (elastic#1355) Close the read pipe at the right moment (elastic#1351) ...

github-actions bot added the agent-ruby label Feb 20, 2023

reakaleek force-pushed the feature/fix-docker-images branch from daf6cef to 68ebe05 Compare February 20, 2023 15:41

reakaleek self-assigned this Feb 20, 2023

reakaleek mentioned this pull request Mar 6, 2023

Migrate Jenkinsfile 2 GH Actions Workflow #1366

Merged

reakaleek requested review from a team March 7, 2023 16:06

reakaleek marked this pull request as ready for review March 7, 2023 16:06

reakaleek commented Mar 7, 2023

View reviewed changes

.ci/docker/jruby/test.sh Outdated Show resolved Hide resolved

v1v reviewed Mar 7, 2023

View reviewed changes

.ci/docker/jruby/test.sh Outdated Show resolved Hide resolved

v1v approved these changes Mar 7, 2023

View reviewed changes

reakaleek added 6 commits March 8, 2023 09:09

Dynamically check sha256 checksum

80b308d

Fix gcc install step

48ada26

Fix gem install steps

58df35b

Return correct exit codes

f36820f

cleanup

bc14baa

cleanup

cc59359

reakaleek force-pushed the feature/fix-docker-images branch from f0e7c35 to cc59359 Compare March 8, 2023 08:09

reakaleek added 2 commits March 8, 2023 10:29

Add ability to exclude multiple folders and exclude 7-jdk by default

1089887

Update README

d281048

v1v reviewed Mar 8, 2023

View reviewed changes

.ci/docker/jruby/run.sh Outdated Show resolved Hide resolved

.ci/docker/jruby/test.sh Outdated Show resolved Hide resolved

reakaleek and others added 3 commits March 8, 2023 10:36

Simplify

6a8de8b

Fix indent

adb0e20

Update .ci/docker/jruby/test.sh

50dfbea

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

v1v approved these changes Mar 8, 2023

View reviewed changes

reakaleek mentioned this pull request Mar 8, 2023

Publish jruby images in dockerhub elastic/apm-pipeline-library#2125

Merged

reakaleek commented Mar 9, 2023

View reviewed changes

estolfo approved these changes Mar 9, 2023

View reviewed changes

reakaleek merged commit 7886850 into elastic:main Mar 9, 2023

reakaleek deleted the feature/fix-docker-images branch March 9, 2023 09:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix jruby docker images #1367

Fix jruby docker images #1367

Uh oh!

reakaleek commented Feb 20, 2023 •

edited

Loading

ghost commented Feb 20, 2023 •

edited by ghost

Loading

Build stats

Test stats 🧪

reakaleek commented Feb 20, 2023 •

edited

Loading

ghost commented Feb 20, 2023 •

edited by ghost

Loading

v1v commented Feb 20, 2023

Uh oh!

Uh oh!

v1v left a comment

Uh oh!

Uh oh!

estolfo commented Mar 9, 2023

reakaleek Mar 9, 2023 •

edited

Loading

estolfo Mar 9, 2023

reakaleek Mar 9, 2023

estolfo Mar 9, 2023

Labels

3 participants

Fix jruby docker images #1367

Fix jruby docker images #1367

Uh oh!

Conversation

reakaleek commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Context

How to test

Related Issues

ghost commented Feb 20, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

reakaleek commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ghost commented Feb 20, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

v1v commented Feb 20, 2023

Uh oh!

Uh oh!

v1v left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

estolfo commented Mar 9, 2023

reakaleek Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

estolfo Mar 9, 2023

Choose a reason for hiding this comment

reakaleek Mar 9, 2023

Choose a reason for hiding this comment

estolfo Mar 9, 2023

Choose a reason for hiding this comment

Labels

3 participants

reakaleek commented Feb 20, 2023 •

edited

Loading

ghost commented Feb 20, 2023 •

edited by ghost

Loading

reakaleek commented Feb 20, 2023 •

edited

Loading

ghost commented Feb 20, 2023 •

edited by ghost

Loading

reakaleek Mar 9, 2023 •

edited

Loading