Skip to content

Conversation

jaggederest
Copy link
Contributor

@jaggederest jaggederest commented May 3, 2022

What does this pull request do?

Removes warnings issued when running the tests about TimeTask timeout being ignored

Why is it important?

Extra noise in the tests and logs can obscure other problems

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

@jaggederest jaggederest requested a review from estolfo May 3, 2022 00:05
@ghost
Copy link

ghost commented May 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-16T12:52:16.543+0000

  • Duration: 26 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 44189
Skipped 80
Total 44269

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jaggederest
Copy link
Contributor Author

/test

@ghost
Copy link

ghost commented May 12, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 99.2% (124/125)
Classes 99.2% (124/125)
Lines 59.647% (2498/4188)
Conditionals 100.0% (0/0) 💚
@jaggederest jaggederest merged commit cc3f4c3 into elastic:main May 16, 2022
@jaggederest jaggederest deleted the timetask_warning_removal branch May 16, 2022 22:07
estolfo pushed a commit that referenced this pull request Mar 2, 2023
* Remove warnings about TimeTask timeouts * Update changelog for #1255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant