Catch and log any exceptions while closing the transport #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Previously these would show up as big tracebacks in the logs which was ugly, considering all sorts of things can go wrong when suddenly closing the transport (such as when a celery worker terminates) Fixes elastic#823
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Log outputExpand to view the last 100 lines of log output
|
I don't know how this happened, I think black added it? But then it didn't re-add it this time when I removed it. Probably more of black's magic comma stuff that has been added recently
beniwohli approved these changes Jun 5, 2020
| self.queue("close", None) | ||
| if not self._flushed.wait(timeout=self._max_flush_time): | ||
| raise ValueError("close timed out") | ||
| logger.error("Closing the transport connection timed out.") |
There was a problem hiding this comment.
I wonder if we additionally also should use a shorter timeout than max_flush_time. Maybe 2s?
There was a problem hiding this comment.
Hmmm. I can potentially see the reasoning, but let's assume the user has upped the api_request_time because they're on a slow network (or for some other reason). I don't particularly want to lose data due to being impatient at close time.
I think I'm going to leave it, unless you think there's a hole in my reasoning?
| More flakey tests. Merging. |
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this pull request Oct 15, 2020
* Catch and log any exceptions while closing the transport Previously these would show up as big tracebacks in the logs which was ugly, considering all sorts of things can go wrong when suddenly closing the transport (such as when a celery worker terminates) Fixes elastic#823 * Remove trailing comma I don't know how this happened, I think black added it? But then it didn't re-add it this time when I removed it. Probably more of black's magic comma stuff that has been added recently * Add to changelog
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this pull request Oct 15, 2020
* Catch and log any exceptions while closing the transport Previously these would show up as big tracebacks in the logs which was ugly, considering all sorts of things can go wrong when suddenly closing the transport (such as when a celery worker terminates) Fixes elastic#823 * Remove trailing comma I don't know how this happened, I think black added it? But then it didn't re-add it this time when I removed it. Probably more of black's magic comma stuff that has been added recently * Add to changelog
beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
* Catch and log any exceptions while closing the transport Previously these would show up as big tracebacks in the logs which was ugly, considering all sorts of things can go wrong when suddenly closing the transport (such as when a celery worker terminates) Fixes elastic#823 * Remove trailing comma I don't know how this happened, I think black added it? But then it didn't re-add it this time when I removed it. Probably more of black's magic comma stuff that has been added recently * Add to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously these would show up as big tracebacks in the logs which
were ugly, considering all sorts of things can go wrong when suddenly
closing the transport (such as when a celery worker terminates)
Fixes #823