Skip to content

Conversation

@bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Apr 7, 2020

What does this pull request do?

This PR adds the Dynamic badge to supported configurations:

  • capture_headers
  • capture_body
  • api_request_size
  • api_request_time
  • span_frames_min_duration
  • transaction_sample_rate
  • transaction_max_spans

It also adds a section on Dynamic configuration.

@beniwohli, I'm using the Python docs as a guinea pig for the Agent documentation. What do you think of this approach?

Documentation preview

http://apm-agent-python_794.docs-preview.app.elstc.co/diff

Screenshot

Screen Shot 2020-04-07 at 9 51 18 AM

Related issues

For elastic/apm#232
For https://github.com/elastic/observability-dev/issues/639

@bmorelli25 bmorelli25 added the docs label Apr 7, 2020
@bmorelli25 bmorelli25 requested a review from beniwohli April 7, 2020 16:47
@bmorelli25 bmorelli25 self-assigned this Apr 7, 2020
@bmorelli25 bmorelli25 changed the title docs: add dynamic bade to config docs: document dynamic configuration options Apr 7, 2020
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @bmorelli25

@bmorelli25
Copy link
Member Author

jenkins retest please

@bmorelli25 bmorelli25 merged commit 0182689 into elastic:master Apr 8, 2020
@bmorelli25 bmorelli25 deleted the reloadable-config branch April 8, 2020 17:40
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this pull request Oct 15, 2020
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this pull request Oct 15, 2020
beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants