feat(dbapi2): include object name in procedure call spans #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 💚 CLA has been signed |
github-actions bot added agent-python community 
| Please merge/rebase this against |
basepi requested changes Nov 28, 2023
| Thanks for the comments, I'll add the tests. Regarding the access I don't see a checkbox.. probably because of the cross-org issue mentioned here: https://github.com/orgs/community/discussions/5634 |
anderssonjohan force-pushed the 1937-action-and-object-name-for-execute-statements branch from 72a0933 to 4cd8fe1 Compare 
Include the name of the procedure in the name of the span. Examples: CALL procedure() EXECUTE procedure Issue: elastic#1937
Set span action to exec instead of query for procedure calls not using callproc(). Issue: elastic#1937
anderssonjohan force-pushed the 1937-action-and-object-name-for-execute-statements branch from 4cd8fe1 to 4bd91b0 Compare basepi approved these changes Dec 1, 2023
| @elasticmachine, run elasticsearch-ci/docs |
| Example output when trying this branch in a real app:
Action set to
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
execwhen calling proceduresRelated issues
Closes #1937