Skip to content

fix "IndexError when "url" not found in args or kwargs" #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 6, 2023
Merged

fix "IndexError when "url" not found in args or kwargs" #1890

merged 6 commits into from
Sep 6, 2023

Conversation

nbarbey
Copy link
Contributor

@nbarbey nbarbey commented Aug 23, 2023 •
edited by basepi
Loading

Closes #1884
@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Aug 23, 2023
@nbarbey nbarbey mentioned this pull request Aug 23, 2023
Closed
@cla-checker-service
Copy link

cla-checker-service bot commented Aug 23, 2023 •
edited
Loading

💚 CLA has been signed
@basepi
Copy link
Contributor

basepi commented Aug 23, 2023

@nbarbey I opened a PR against your PR, with a test and a little fix: https://github.com/nbarbey/apm-agent-python/pull/1

If you open PRs from a new branch instead of your main branch, it allows me to push changes directly to your PR, rather than having to open a new PR against your PR. Should make it easier next time. Thanks for the contribution!
@nbarbey
Copy link
Contributor Author

nbarbey commented Aug 25, 2023

Ok I will be more careful next time about branch name.
I merge your PR in my fork. It seems it updated this PR automagically, nice !
@basepi
Copy link
Contributor

basepi commented Aug 25, 2023

@elasticmachine, run elasticsearch-ci/docs
@basepi basepi enabled auto-merge (squash) August 25, 2023 17:21
basepi
basepi requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change I missed to get the tests passing.
auto-merge was automatically disabled September 6, 2023 13:05

Head branch was pushed to by a user without write access

@basepi basepi enabled auto-merge (squash) September 6, 2023 18:54
@basepi
Copy link
Contributor

basepi commented Sep 6, 2023

@elasticmachine, run elasticsearch-ci/docs
@basepi basepi merged commit 0c1ff43 into elastic:main Sep 6, 2023
basepi added a commit to basepi/apm-agent-python that referenced this pull request Sep 6, 2023
@basepi
CHANGELOG for elastic#1890
88b7da1
@basepi basepi mentioned this pull request Sep 6, 2023
Merged
basepi added a commit that referenced this pull request Sep 6, 2023
@basepi
CHANGELOG for #1890 (#1898)
be5f6b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-python community Issues opened by the community triage Issues awaiting triage

2 participants

@nbarbey @basepi