Support Psycopg3 synchronous operations #1841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 💚 CLA has been signed |
github-actions bot added agent-python community 
minhtule force-pushed the support-psycopg3 branch 2 times, most recently from f316d3d to 903157c Compare 
minhtule force-pushed the support-psycopg3 branch from 903157c to ef2d870 Compare 
minhtule commented May 28, 2023
| @mariocandela could you test this as well? I know your team was looking for this instrumentation. |
| @minhtule This is awesome! Thank you for being so thorough and even including tests! I should be able to get this properly reviewed today. |
basepi approved these changes May 30, 2023
There was a problem hiding this comment.
This looks great! I'm going to get @beniwohli to take a look as well and then we can get this merged!
| @basepi @beniwohli Thank you very much for your quick response and review! 🙏 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Support Psycopg3 synchronous operations by instrumenting
psycopg.connect. AddPsycopgInstrumentationwhich adoptsPsycopg2Instrumentation.psycopg(notpsycopg3) because Psycopg3's module name ispsycopg.Related issues
Closes #1789